Bug 2188675

Summary: Review Request: golang-github-moby-pubsub - None
Product: [Fedora] Fedora Reporter: Sergio Basto <sergio>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, maxwell, package-review
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: xavier: fedora-review?
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-02-27 19:54:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 201449    

Description Sergio Basto 2023-04-21 15:07:51 UTC
Spec URL: https://sergiomb.fedorapeople.org/golang-github-moby-pubsub/golang-github-moby-pubsub.spec
SRPM URL: https://sergiomb.fedorapeople.org/golang-github-moby-pubsub/golang-github-moby-pubsub-1.0.0-1.fc39.src.rpm

Description:
golang-github-moby-pubsub

Fedora Account System Username: sergiomb

Comment 1 Sergio Basto 2023-04-21 15:07:54 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=100216997

Comment 2 Maxwell G 2023-04-21 22:46:01 UTC
Please change `%gometa -f` to `%gometa` and replace `%global common_description` and Summary with more useful text.

Comment 3 Sergio Basto 2023-04-21 23:41:20 UTC
(In reply to Maxwell G from comment #2)
> Please change `%gometa -f` to `%gometa` and replace `%global
> common_description` and Summary with more useful text.

done in the same locations

Comment 4 Robert-André Mauchin 🐧 2023-08-14 16:36:45 UTC
 - Add a Summary and a valid Description.

Like:

%global common_description %{expand:
Concurrent Go library for broadcasting messages to subscribers with optional
topic filtering and send timeouts}

Summary:        Concurrent Go library for broadcasting messages to subscribers

 - Use autorelease/autochangelog please

 - Add a new line between these:

%global golicenses      NOTICE LICENSE
Name:           %{goname}

 - Read the notice:

> This product contains software (https://github.com/creack/pty) developed
> by Keith Rarick, licensed under the MIT License.

And this add MIT to the License field and a comment explaining why:

# Apache 2.0: main codegithub.com/creack/pty
# This product contains software (https://github.com/creack/pty) developed
# by Keith Rarick, licensed under the MIT License.
License:        Apache-2.0 AND MIT
URL:            %{gourl}
Source:         %{gosource}

Please update your SPEC accordingly and needinfo me.

Comment 5 Package Review 2023-09-14 00:45:22 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.