Bug 2188676
| Summary: | Review Request: golang-github-azure-ansiterm - Go package for ANSI terminal emulation in Windows | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sergio Basto <sergio> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zebob.m |
| Target Milestone: | --- | Flags: | zebob.m:
needinfo?
(sergio) |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sergio Basto
2023-04-21 15:10:28 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=100216993 - Please use autorelease/autochangelog - Isn't this a Windows only package? Which one of your package is requiring it? usually it's only a dep in _windows.go file, which are excluded by the build system and the macros. The only notable package that requires it is moby/moby, in a test: https://github.com/moby/moby/blob/v24.0.5/integration/internal/termtest/stripansi.go And github.com/moby/term, which is packaged but it is not called because in windows files. I'd patch it out from moby: https://github.com/moby/moby/commit/2ec3e14c0ff7f8552c1f9b09ffde743632fa1f8c From 873a4b6552fcdbf60299e51de3139465da6b2a92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert-Andr=C3=A9=20Mauchin?= <zebob.m> Date: Mon, 14 Aug 2023 19:11:59 +0200 Subject: [PATCH] Make call to Azure/go-ansiterm Windows-only --- integration/internal/termtest/stripansi_default.go | 10 ++++++++++ .../{stripansi_test.go => stripansi_test_windows.go} | 0 .../termtest/{stripansi.go => stripansi_windows.go} | 0 3 files changed, 10 insertions(+) create mode 100644 integration/internal/termtest/stripansi_default.go rename integration/internal/termtest/{stripansi_test.go => stripansi_test_windows.go} (100%) rename integration/internal/termtest/{stripansi.go => stripansi_windows.go} (100%) diff --git a/integration/internal/termtest/stripansi_default.go b/integration/internal/termtest/stripansi_default.go new file mode 100644 index 0000000000..8557c8bf72 --- /dev/null +++ b/integration/internal/termtest/stripansi_default.go @@ -0,0 +1,10 @@ +package termtest // import "github.com/docker/docker/integration/internal/termtest" + +import ( + "errors" +) + +// StripANSICommands provides a dummy implementation for non-Windows platforms. +func StripANSICommands(input string) (string, error) { + return input, errors.New("StripANSICommands is not implemented for this platform") +} diff --git a/integration/internal/termtest/stripansi_test.go b/integration/internal/termtest/stripansi_test_windows.go similarity index 100% rename from integration/internal/termtest/stripansi_test.go rename to integration/internal/termtest/stripansi_test_windows.go diff --git a/integration/internal/termtest/stripansi.go b/integration/internal/termtest/stripansi_windows.go similarity index 100% rename from integration/internal/termtest/stripansi.go rename to integration/internal/termtest/stripansi_windows.go -- 2.41.0 Pushed upstream: https://github.com/moby/moby/pull/46234 Not tested but it should work. Let me know if you really need it. Filename was wrong, take this patch instead https://patch-diff.githubusercontent.com/raw/moby/moby/pull/46234.patch |