Bug 2189518

Summary:	Rebase boom to upcoming 1.5 release
Product:	Red Hat Enterprise Linux 9	Reporter:	Bryn M. Reeves <bmr>
Component:	boom-boot	Assignee:	LVM Team <lvm-team>
Status:	VERIFIED ---	QA Contact:	cluster-qe <cluster-qe>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	9.2	CC:	agk, bmr, cmarthal, dkeefe, jbrassow, mcsontos, mgandhi
Target Milestone:	rc	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	boom-boot-1.5.1-1.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	2189522 (view as bug list)		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2189522

Description Bryn M. Reeves 2023-04-25 13:44:41 UTC

Description of problem:
The boom project will soon release boom-1.5 upstream which includes a number of fixes and enhancements:

  * Automatic command line options templates (bug 1663864)
  * Fixes for command line option overrides (bug 2184755, bug 2046433)
  * Documentation improvements for --expand-variables (bug 2026915)
  * Removal of obsolete grub config warnings (bug 2046360)
  
Version-Release number of selected component (if applicable):
boom-boot-1.4-4.el9

How reproducible:
100%

Steps to Reproduce:
1. rpm -q boom-boot

Actual results:
boom-1.4 release

Expected results:
boom-1.5 release

Additional info:

Comment 1 Bryn M. Reeves 2023-05-04 16:42:31 UTC

The boom 1.5 release has been superseded by 1.5.1 which corrects the reported version and package metadata:

  https://github.com/snapshotmanager/boom/releases/tag/1.5.1

Comment 4 Corey Marthaler 2023-06-05 22:32:31 UTC

Regression test scenarios pass with the latest rpms, marking Verified:Tested (SanityOnly)

boom-boot-1.5.1-1.el9    BUILT: Wed May 17 03:00:49 PM CEST 2023
kernel-5.14.0-312.el9    BUILT: Thu May 11 08:04:19 PM CEST 2023
lvm2-2.03.21-2.el9    BUILT: Thu May 25 12:03:04 AM CEST 2023



Making origin volume
lvcreate --yes -L 300M snapper -n origin
Making snapshot of origin volume
lvcreate --yes -s /dev/snapper/origin -c 128 -n boom_snap -L 100M

Check 0 a. Verify a new profile can be created (this is basically a dup of the above cmd)
boom profile create --from-host --uname-pattern Linux
Check 0 b. Verify a new profile can be created automatically from just current host heuristic
boom profile create --from-host
Check 0 c. Verify a new profile can be created
boom profile create --from-host --uname-pattern el9

Check 1. Verify blscfg is configured w/ grub and boom (New in RHEL9.1, we are no longer concerned w/ boom in grub.cfg)
Generating grub configuration file ...
Adding boot menu entry for UEFI Firmware Settings ...
done

Check 2 a. Verify version numbers not matching an OS profile provide a helpful warning (Bug 1771584#c5)
boom create --title nomatchversion --rootlv snapper/boom_snap --version 2.5.0
Check 2 b. Verify fake OS profiles are properly identified (Bug 1540266)
boom create --profile fake_profile --title title --version 3.10-272.el7 --rootlv snapper/boom_snap

Check 3. Verify --rootlv and --root-device variations are both accepted (Bug 1543188)
[--rootlv]: boom create --title 1 --rootlv /dev/snapper/boom_snap
boom list 7f40acf
BootID  Version                  Name                     RootDevice            
7f40acf 5.14.0-312.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom entry show 7f40acf
Boot Entry (boot_id=7f40acf)
  title 1
  machine-id c3af67c026d4445a8e38bad5ae16d7f5
  version 5.14.0-312.el9.x86_64
  linux /vmlinuz-5.14.0-312.el9.x86_64
  initrd /initramfs-5.14.0-312.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M resume=/dev/mapper/rhel_virt--521-swap rd.lvm.lv=rhel_virt-521/swap console=ttyS0,115200
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
boom delete 7f40acf

[--root-lv]: boom create --title 2 --root-lv /dev/snapper/boom_snap
boom list b8bf143
BootID  Version                  Name                     RootDevice            
b8bf143 5.14.0-312.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom entry show b8bf143
Boot Entry (boot_id=b8bf143)
  title 2
  machine-id c3af67c026d4445a8e38bad5ae16d7f5
  version 5.14.0-312.el9.x86_64
  linux /vmlinuz-5.14.0-312.el9.x86_64
  initrd /initramfs-5.14.0-312.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M resume=/dev/mapper/rhel_virt--521-swap rd.lvm.lv=rhel_virt-521/swap console=ttyS0,115200
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
boom delete b8bf143

[--rootdevice]: boom create --title 3 --rootdevice /dev/snapper/boom_snap
boom list 8cdfeb8
BootID  Version                  Name                     RootDevice            
8cdfeb8 5.14.0-312.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom entry show 8cdfeb8
Boot Entry (boot_id=8cdfeb8)
  title 3
  machine-id c3af67c026d4445a8e38bad5ae16d7f5
  version 5.14.0-312.el9.x86_64
  linux /vmlinuz-5.14.0-312.el9.x86_64
  initrd /initramfs-5.14.0-312.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M resume=/dev/mapper/rhel_virt--521-swap rd.lvm.lv=rhel_virt-521/swap console=ttyS0,115200
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
boom delete 8cdfeb8

[--root-device]: boom create --title 4 --root-device /dev/snapper/boom_snap
boom list 471769a
BootID  Version                  Name                     RootDevice            
471769a 5.14.0-312.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom entry show 471769a
Boot Entry (boot_id=471769a)
  title 4
  machine-id c3af67c026d4445a8e38bad5ae16d7f5
  version 5.14.0-312.el9.x86_64
  linux /vmlinuz-5.14.0-312.el9.x86_64
  initrd /initramfs-5.14.0-312.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M resume=/dev/mapper/rhel_virt--521-swap rd.lvm.lv=rhel_virt-521/swap console=ttyS0,115200
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
boom delete 471769a

Check 4. Verify --root-lv and --root-device verify the lv/device exists (Bug 1543186)
boom create --title no-lv --root-lv snapper/nonlv
boom create --title no-dev --root-device /dev/sdxyz
boom create --title 5 --no-dev --root-lv snapper/nonlv
boom delete e679aa6

Check 5. Verify proper use of user providing --rootlv /dev/* format (Bug 1544914)
boom create --title 6 --rootlv /dev/snapper/boom_snap
Created entry with boot_id ebc8624:
  title 6
  machine-id c3af67c026d4445a8e38bad5ae16d7f5
  version 5.14.0-312.el9.x86_64
  linux /vmlinuz-5.14.0-312.el9.x86_64
  initrd /initramfs-5.14.0-312.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M resume=/dev/mapper/rhel_virt--521-swap rd.lvm.lv=rhel_virt-521/swap console=ttyS0,115200
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
boom delete ebc8624

Check 6. Verify proper rd.lvm.lv entry w/ --root-device option (Also listed in Bug 1544914)
boom create --title 7 --root-device /dev/snapper/boom_snap
Created entry with boot_id b3d2a29:
  title 7
  machine-id c3af67c026d4445a8e38bad5ae16d7f5
  version 5.14.0-312.el9.x86_64
  linux /vmlinuz-5.14.0-312.el9.x86_64
  initrd /initramfs-5.14.0-312.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M resume=/dev/mapper/rhel_virt--521-swap rd.lvm.lv=rhel_virt-521/swap console=ttyS0,115200
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
regression check for bug 1840488
boom remove b3d2a29
boom delete b3d2a29

Check 7. Verify --grub-arg, grub-class, grub-users, and grub-id specified arguments (r7 rfe 1777364 / r8 rfe 1848123)
[New in rhel9.1]: boom profile create --from-host --optional-keys "grub_arg grub_users grub_class"
[--grub-arg]: boom create --title 10 --grub-arg 215 --root-lv /dev/snapper/boom_snap
boom list 5a0f78b --expand-variables
BootID  Version                  Name                     RootDevice            
5a0f78b 5.14.0-312.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
grub val not found in expanded list output (possible regression of bug 1840337)
boom entry show 5a0f78b
Boot Entry (boot_id=5a0f78b)
  title 10
  machine-id c3af67c026d4445a8e38bad5ae16d7f5
  version 5.14.0-312.el9.x86_64
  linux /vmlinuz-5.14.0-312.el9.x86_64
  initrd /initramfs-5.14.0-312.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M resume=/dev/mapper/rhel_virt--521-swap rd.lvm.lv=rhel_virt-521/swap console=ttyS0,115200
  grub_users $grub_users
  grub_arg 215
  grub_class kernel
boom delete 5a0f78b

[--grub-class]: boom create --title 11 --grub-class 241 --root-lv /dev/snapper/boom_snap
boom list c0e783b --expand-variables
BootID  Version                  Name                     RootDevice            
c0e783b 5.14.0-312.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
grub val not found in expanded list output (possible regression of bug 1840337)
boom entry show c0e783b
Boot Entry (boot_id=c0e783b)
  title 11
  machine-id c3af67c026d4445a8e38bad5ae16d7f5
  version 5.14.0-312.el9.x86_64
  linux /vmlinuz-5.14.0-312.el9.x86_64
  initrd /initramfs-5.14.0-312.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M resume=/dev/mapper/rhel_virt--521-swap rd.lvm.lv=rhel_virt-521/swap console=ttyS0,115200
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class 241
boom delete c0e783b

[--grub-users]: boom create --title 12 --grub-users 355 --root-lv /dev/snapper/boom_snap
boom list fa4bafe --expand-variables
BootID  Version                  Name                     RootDevice            
fa4bafe 5.14.0-312.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
grub val not found in expanded list output (possible regression of bug 1840337)
boom entry show fa4bafe
Boot Entry (boot_id=fa4bafe)
  title 12
  machine-id c3af67c026d4445a8e38bad5ae16d7f5
  version 5.14.0-312.el9.x86_64
  linux /vmlinuz-5.14.0-312.el9.x86_64
  initrd /initramfs-5.14.0-312.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M resume=/dev/mapper/rhel_virt--521-swap rd.lvm.lv=rhel_virt-521/swap console=ttyS0,115200
  grub_users 355
  grub_arg --unrestricted
  grub_class kernel
boom delete fa4bafe

Removing volume snapper/boom_snap
Removing origin snapper/origin

Comment 8 Corey Marthaler 2023-06-28 19:34:38 UTC

Remaining bugs for this build marked Verified:Tested, moving to VERIFIED.