Bug 219036

Summary: Review Request: perl-Roman - Roman module from CPAN
Product: [Fedora] Fedora Reporter: Sam Varshavchik <mrsam>
Component: Package ReviewAssignee: Jose Pedro Oliveira <jose.p.oliveira.oss>
Status: CLOSED NOTABUG QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
See Also: https://bugzilla.redhat.com/show_bug.cgi?id=1272054
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-06-01 23:29:00 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449    
Attachments:
Description Flags
specfile patch none

Description Sam Varshavchik 2006-12-09 13:44:35 EST
Spec URL: http://www.courier-mta.com/perl-Roman.spec
SRPM URL: http://www.courier-mta.com/perl-Roman-1.1-0.fc.1.src.rpm
Description: 

This is the Roman perl module, from CPAN.
Comment 1 Jose Pedro Oliveira 2006-12-10 10:55:22 EST
NEEDSWORK

MD5SUMS:
3bcd42265a01a9261b18146273872a0d  perl-Roman-1.1-0.fc.1.src.rpm

0ded0e59e44267c803c4c8609ee52523  perl-Roman.spec
67b0e6affdc50fdf28cfc438c045fd9b  Roman-1.1.tar.gz

Sources:
* Roman-1.1.tar.gz: MD5 digest matches the CPAN tarball


NeedsWork:
* wrong release (and dist tag)
* the license information is incomplete: perl is dual licensed
  (GPL or Artistic)
* changelog entry missing
* remove the dot at the end of the summary (rpmlint)


Suggestions:
* change the URL to "http://search.cpan.org/dist/Roman/"
  (no author or version info - easier to maintain)
* the perl build requirement can be dropped
* when copying files try to preserve the timestamps
  (use install with the -p option)
* you can also use install to create the perl directory
  (%{__install} -d -m 0755 $RPM_BUILD_ROOT%{perl_vendorlib})
* don't mix spaces and tabs in the specfile
  (check the release line)
Comment 2 Jose Pedro Oliveira 2006-12-10 11:01:03 EST
Created attachment 143242 [details]
specfile patch

Sam,

The attached patch corrects all the problems mentioned in the previous comment
(also removes a couple of lost spaces and reformats a couple of lines).

jpo
Comment 3 Sam Varshavchik 2006-12-10 21:47:22 EST
Thanks for doing my work for me.  I'll slap myself later, for forgetting to use
rpmlint.

Updated spec file: http://www.courier-mta.com/perl-Roman.spec
Updated SRPM: http://www.courier-mta.com/perl-Roman-1.1-1.src.rpm

Comment 4 Jose Pedro Oliveira 2006-12-11 15:47:02 EST
APPROVED


MD5SUMS:
df12af9eef0433eb70f89c431111c05e  perl-Roman-1.1-1.src.rpm

7c93de8cd3de204072b194a561368629  perl-Roman.spec
67b0e6affdc50fdf28cfc438c045fd9b  Roman-1.1.tar.gz

Sources:
* Roman-1.1.tar.gz: MD5 digest matches the CPAN tarball

Good:
* Package name follows standard
* URL and Source url are OK
* License verified (main pod page and License file)
* perl(:MODULE_COMPAT_xxx) requirement present
* the requirements are sane
* the provides are sane
* perl vendor libs macros present
* File permissions are ok
* Builds without problems in FC-6
* (Un)installs without problems in FC-6
* Runs on FC-6
  (perl -MRoman -e 'print Roman(1004);')
* No opened tickets in
  http://rt.cpan.org/Public/Dist/Display.html?Name=Roman


Random notes about this module:
* no Makefile.PL/Build.PL
* no testsuite
* no VERSION variable


jpo
Comment 5 Jose Pedro Oliveira 2006-12-23 14:14:38 EST
ping!
Comment 6 Sam Varshavchik 2006-12-24 14:57:09 EST
Was this ping directed at me?  Is there something else that I need to do?

Comment 7 Jose Pedro Oliveira 2006-12-26 09:49:31 EST
Sam,

(In reply to comment #6)
> Was this ping directed at me?

Yes.

> Is there something else that I need to do?

Please read 
   http://fedoraproject.org/wiki/Extras/Contributors
and, if this is your first package, see also
   http://fedoraproject.org/wiki/Extras/HowToGetSponsored
   and add FE-NEEDSPONSOR to the blocking list (see step 7 of the first link).

Regards,
jpo
  
Comment 8 Jason Tibbitts 2007-05-06 14:14:27 EDT
Anything happening here?
Comment 9 Jason Tibbitts 2007-05-25 01:05:01 EDT
I guess not; I'll close this bug soon if there is no response.