Bug 219103
| Summary: | Review Request: dvdauthor - Command line DVD authoring tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> |
| Component: | Package Review | Assignee: | Dominik 'Rathann' Mierzejewski <dominik> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dominik, hobbes1069, mr.ecik, panemade, tcallawa |
| Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-01-07 14:22:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Ville Skyttä
2006-12-10 22:19:23 UTC
spot, I think it wouldn't hurt to look at this from the FE-Legal POV as the package touches the DVD and MPEG areas. Could you have a look? Better to have a dicussion on FE mailing list. I'll try to review this once legal doubts are cleared. OK, so in looking at this: - dvdauthor can't encode mpeg - dvdauthor can't decode mpeg - dvdauthor can't play mpeg (duh, it can't encode/decode) - dvdauthor can mux/demux mpeg (this is how it gets into DVD format) - dvdauthor can't decode encrypted DVDs Since mux/demux is ok, this should be ok for Fedora. Lifting FE-Legal. 1. package meets naming and packaging guidelines.
2. specfile is properly named, is cleanly written and uses macros consistently.
3. dist tag is present.
4. build root is correct.
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
5. license field matches the actual license.
6. license is open source-compatible (GPL). License text included in package.
7. source files match upstream:
d2c45879e4cfb95d410bf603af891e07 dvdauthor-0.6.11.tar.gz
8. latest version is being packaged.
9. BuildRequires are proper.
10. package builds in mock (x86_64 devel).
11. rpmlint is silent.
12. final provides and requires are sane:
dvdauthor = 0.6.11-8.fc7
=
/bin/sh
libc.so.6()(64bit)
libdvdread.so.3()(64bit)
libfreetype.so.6()(64bit)
libfribidi.so.0()(64bit)
libm.so.6()(64bit)
libpng12.so.0()(64bit)
libxml2.so.2()(64bit)
libz.so.1()(64bit)
13. no shared libraries are present.
14. package is not relocatable.
15. owns the directories it creates.
16. doesn't own any directories it shouldn't.
17. no duplicates in %files.
18. file permissions are appropriate.
19. %clean is present.
20. %check is not present and no testsuite.
21. no scriptlets present.
22. code, not content.
23. documentation is small, so no -docs subpackage is necessary.
24. %docs are not necessary for the proper functioning of the package.
25. no headers.
26. no pkgconfig files.
27. no libtool .la droppings.
28. not a GUI app.
29. not a web app.
APPROVED.
Oops forgot to set ASSIGNED. Devel build done, owners.list and comps-fe7 updated, FC-6 branch requested. Thanks! Package Change Request ====================== Package Name: dvdauthor New Branches: el6 Owners: hobbes1069 InitialCC: Git done (by process-git-requests). |