Bug 2192234
| Summary: | Symlinks for letsencrypt/certbot are weird | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Adams <linux> |
| Component: | certbot | Assignee: | Nick Bebout <nb> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 37 | CC: | anon.amish, certbot-sig, luk.claes, mattias.ellert, nb |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
In addition, the symlinks in /usr/share/doc/certbot are broken, pointing to non-existing files: [root@fedora ~]# ls -l /usr/share/doc/certbot totalt 4 lrwxrwxrwx. 1 root root 20 9 maj 21.45 CHANGELOG.md -> certbot/CHANGELOG.md -rw-r--r--. 1 root root 524 22 maj 02.00 README.fedora lrwxrwxrwx. 1 root root 18 9 maj 21.45 README.rst -> certbot/README.rst As are the one in /usr/share/doc/python3-certbot and /usr/share/doc/python3-acme: [root@fedora ~]# ls -l /usr/share/doc/python3-certbot totalt 0 lrwxrwxrwx. 1 root root 20 9 maj 21.45 CHANGELOG.md -> certbot/CHANGELOG.md lrwxrwxrwx. 1 root root 18 9 maj 21.45 README.rst -> certbot/README.rst [root@fedora ~]# ls -l /usr/share/doc/python3-acme totalt 0 lrwxrwxrwx. 1 root root 20 9 maj 21.45 CHANGELOG.md -> certbot/CHANGELOG.md lrwxrwxrwx. 1 root root 18 9 maj 21.45 README.rst -> certbot/README.rst I suspect the intention was that /usr/share/doc/certbot/CHANGELOG.md and /usr/share/doc/certbot/README.rst should have been the regular files, i.e. not symlinks, and that the ones in the python package should point to those, e.g. the ../ is missing: lrwxrwxrwx. 1 root root 20 9 maj 21.45 CHANGELOG.md -> ../certbot/CHANGELOG.md lrwxrwxrwx. 1 root root 18 9 maj 21.45 README.rst -> ../certbot/README.rst |
The symlinks for /usr/bin/letsencrypt and /usr/bin/certbot are created with the -r option to ln, which creates links relative to the buildroot, not the install root, so they look like: lrwxrwxrwx 1 root root 35 Apr 30 13:10 /usr/bin/certbot -> ../../../../../../usr/bin/certbot-3 lrwxrwxrwx 1 root root 33 Apr 30 13:10 /usr/bin/letsencrypt -> ../../../../../../usr/bin/certbot There's no need for this (and it can be wrong when an RPM is manually extracted to a temp directory for examination for example). In fact, they don't even need a path (since they're linking to something in the same directory). Just doing: ln -s certbot %{buildroot}%{_bindir}/%{oldpkg} ln -s certbot-3 %{buildroot}%{_bindir}/certbot would work fine. Reproducible: Always