Bug 2192939

Summary:	Puppet reports without any messages don't get an origin
Product:	Red Hat Satellite	Reporter:	Ewoud Kohl van Wijngaarden <ekohlvan>
Component:	Puppet	Assignee:	Ewoud Kohl van Wijngaarden <ekohlvan>
Status:	POST ---	QA Contact:	Satellite QE Team <sat-qe-bz-list>
Severity:	medium	Docs Contact:
Priority:	high
Version:	6.13.0	CC:	akaiser, bskopova, nalfassi, osousa, sadas
Target Milestone:	Unspecified	Keywords:	Regression, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ewoud Kohl van Wijngaarden 2023-05-03 15:56:45 UTC

Description of problem:

Since https://projects.theforeman.org/issues/35684 Puppet reports without messages can come in. The current Puppet report scanner looks at the last log message to determine the source, but if there is no message there is no way to identify it.

Version-Release number of selected component (if applicable):

Foreman 3.4.0, so Satellite 6.13.0

How reproducible:

Always

Steps to Reproduce:

1. Run puppet agent -t --detailed-exitcodes and ensure its exit code is 0 (meaning no changes)
2. Look for Puppet reports on the host
3. Expect to find the new report with origin Puppet

Actual results:

A report is created, but without an origin

Expected results:

The origin Puppet is set.

Additional info:

The Puppet origin is derived from the messages, but if there are no messages then it can't.

Comment 1 Bryan Kearney 2023-05-03 16:03:34 UTC

Upstream bug assigned to ekohlvan

Comment 2 Bryan Kearney 2023-05-03 16:03:36 UTC

Upstream bug assigned to ekohlvan

Comment 3 Brad Buckingham 2023-05-04 15:22:03 UTC

*** Bug 2192937 has been marked as a duplicate of this bug. ***

Comment 9 Ewoud Kohl van Wijngaarden 2023-06-19 08:28:22 UTC

I've been thinking about this and it's probably best to revert the problematic commit in the short term so I've opened https://github.com/theforeman/puppet-puppetserver_foreman/pull/29 for now.