Bug 2193287

Summary:	cjs fails testsuite when libffi configured with static trampolines
Product:	[Fedora] Fedora	Reporter:	DJ Delorie <dj>
Component:	cjs	Assignee:	leigh scott <leigh123linux>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	epel-packagers-sig, leigh123linux, raveit65.sun, riehecky
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	cjs-5.8.0-1.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-06 02:18:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description DJ Delorie 2023-05-05 03:32:38 UTC

If you remove the --disable-exec-static-tramp option from libffi's spec file (see proposed change LIBFFI34_static_trampolines) cjs's build fails in the testsuite phase.


Reproducible: Always

Steps to Reproduce:
1. Install a libffi with static trampolines (for example, https://copr.fedorainfracloud.org/coprs/djdelorie/libffi-3.4.4/build/5865818/)
2. rpm install cjs src.rpm
3. rpmbuild -ba cjs.spec
Actual Results:  
about 2/3 of the tests fail

Expected Results:  
all tests pass

We noted that the gi/* implementation in cjs upstream is behind the equivalent gi/* in gjs upstream, and is missing at least two closure-related commits:

8e1c28156b32765b4f6b2e41007281ddb07ccdee gi: fix the usage of closure in CallbackIn::release
bcf9feeb96678ec698d76c4f7cb1dbc465972ad5 gi: Use new GObject Introspection callable API

The first looks very relevent but was not trivially apply-able to the cjs sources.

Comment 1 leigh scott 2023-05-05 07:10:16 UTC

cjs will be rebased for 5.8.x release.

https://github.com/linuxmint/cjs/pull/111

Comment 2 DJ Delorie 2023-05-05 16:34:17 UTC

Noting that this is a dependency for the libffi static trampoline change request:
https://fedoraproject.org/wiki/Changes/LIBFFI34_static_trampolines

Thanks!

Comment 3 leigh scott 2023-05-05 17:05:38 UTC

(In reply to DJ Delorie from comment #2)
> Noting that this is a dependency for the libffi static trampoline change
> request:
> https://fedoraproject.org/wiki/Changes/LIBFFI34_static_trampolines
> 
> Thanks!

This fixes the build issue for now and switch to git snapshots once the required changes are merged.


https://src.fedoraproject.org/rpms/cjs/c/28d5d2330edbcd0f312f7ad07e9588a850efd9b9?branch=rawhide

Comment 4 DJ Delorie 2023-05-05 18:01:05 UTC

that works for me.  Thanks!

Comment 5 leigh scott 2023-05-09 21:41:57 UTC

F39 cjs is now built against mozjs102.

https://bodhi.fedoraproject.org/updates/FEDORA-2023-b57fd5b3bc

Comment 6 Fedora Update System 2023-06-08 22:20:04 UTC

FEDORA-2023-27423db0aa has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-27423db0aa

Comment 7 Fedora Update System 2023-06-09 01:40:17 UTC

FEDORA-2023-27423db0aa has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-27423db0aa`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-27423db0aa

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-06-24 01:08:10 UTC

FEDORA-2023-27423db0aa has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-27423db0aa`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-27423db0aa

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-06-28 01:01:02 UTC

FEDORA-2023-27423db0aa has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-27423db0aa`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-27423db0aa

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-07-06 02:18:17 UTC

FEDORA-2023-27423db0aa has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.