Bug 2193288
| Summary: | Review Request: f3d - Fast and minimalist 3D viewer. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Felix Wang <topazus> | ||||||
| Component: | Package Review | Assignee: | Benson Muite <benson_muite> | ||||||
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | benson_muite, package-review | ||||||
| Target Milestone: | --- | Keywords: | Desktop | ||||||
| Target Release: | --- | Flags: | benson_muite:
fedora-review?
|
||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/f3d-app/f3d | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Felix Wang
2023-05-05 03:41:11 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5875067 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2193288-f3d/fedora-rawhide-x86_64/05875067-f3d/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License", "*No copyright* [generated file]", "MIT License". 693 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/f3d/2193288-f3d/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/scalable, /usr/share/mime, /usr/share/icons/hicolor/48x48/apps, /usr/share/mime/packages [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/thumbnailers(mypaint, libjxl, gnome-directory-thumbnailer, gdk-pixbuf2, librsvg2, gnome-epub-thumbnailer, gnome-kra-ora- thumbnailer, libgsf, tiled, eom) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: f3d-2.0.0-1.fc39.x86_64.rpm f3d-devel-2.0.0-1.fc39.x86_64.rpm f3d-python3-f3d-2.0.0-1.fc39.x86_64.rpm f3d-debuginfo-2.0.0-1.fc39.x86_64.rpm f3d-debugsource-2.0.0-1.fc39.x86_64.rpm f3d-2.0.0-1.fc39.src.rpm =========================================================== rpmlint session starts ========================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpi1nsw8sl')] checks: 31, packages: 6 f3d-devel.x86_64: W: only-non-binary-in-usr-lib f3d.x86_64: W: no-soname /usr/lib64/libf3d-plugin-alembic.so f3d.x86_64: W: no-soname /usr/lib64/libf3d-plugin-assimp.so f3d.x86_64: W: no-soname /usr/lib64/libf3d-plugin-exodus.so f3d.x86_64: W: no-soname /usr/lib64/libf3d-plugin-occt.so f3d-devel.x86_64: W: no-documentation f3d-python3-f3d.x86_64: W: no-documentation f3d.x86_64: E: invalid-soname /usr/lib64/libf3d.so libf3d.so f3d.x86_64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_alembic.json /usr/share/f3d/configs/config.d/10_alembic.json f3d.x86_64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_assimp.json /usr/share/f3d/configs/config.d/10_assimp.json f3d.x86_64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_occt.json /usr/share/f3d/configs/config.d/10_occt.json =========================== 6 packages and 0 specfiles checked; 1 errors, 10 warnings, 1 badness; has taken 9.3 s =========================== Rpmlint (debuginfo) ------------------- Checking: f3d-debuginfo-2.0.0-1.fc39.x86_64.rpm =========================================================== rpmlint session starts ========================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppl1y0d_v')] checks: 31, packages: 1 ============================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 2.6 s =========================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5 f3d-devel.x86_64: W: only-non-binary-in-usr-lib f3d.x86_64: W: no-soname /usr/lib64/libf3d-plugin-alembic.so f3d.x86_64: W: no-soname /usr/lib64/libf3d-plugin-assimp.so f3d.x86_64: W: no-soname /usr/lib64/libf3d-plugin-exodus.so f3d.x86_64: W: no-soname /usr/lib64/libf3d-plugin-occt.so f3d-devel.x86_64: W: no-documentation f3d-python3-f3d.x86_64: W: no-documentation f3d.x86_64: E: invalid-soname /usr/lib64/libf3d.so libf3d.so f3d.x86_64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_alembic.json /usr/share/f3d/configs/config.d/10_alembic.json f3d.x86_64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_assimp.json /usr/share/f3d/configs/config.d/10_assimp.json f3d.x86_64: W: files-duplicate /usr/share/f3d/configs/thumbnail.d/10_occt.json /usr/share/f3d/configs/config.d/10_occt.json 5 packages and 0 specfiles checked; 1 errors, 10 warnings, 1 badness; has taken 10.8 s Unversioned so-files -------------------- f3d: /usr/lib64/libf3d-plugin-alembic.so f3d: /usr/lib64/libf3d-plugin-assimp.so f3d: /usr/lib64/libf3d-plugin-exodus.so f3d: /usr/lib64/libf3d-plugin-occt.so f3d: /usr/lib64/libf3d.so f3d-python3-f3d: /usr/lib64/python3.11/site-packages/f3d.cpython-311-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/f3d-app/f3d/archive/v2.0.0/f3d-2.0.0.tar.gz : CHECKSUM(SHA256) this package : 5b335de78a9f68903d7023d947090d4b36fa15b9e165749906a82153e0f56d05 CHECKSUM(SHA256) upstream package : 5b335de78a9f68903d7023d947090d4b36fa15b9e165749906a82153e0f56d05 Requires -------- f3d (rpmlib, GLIBC filtered): glibc libAlembic.so.1.8()(64bit) libGLEW.so.2.2()(64bit) libOpenGL.so.0()(64bit) libTKBRep.so.7()(64bit) libTKIGES.so.7()(64bit) libTKLCAF.so.7()(64bit) libTKMath.so.7()(64bit) libTKMesh.so.7()(64bit) libTKXCAF.so.7()(64bit) libTKXDEIGES.so.7()(64bit) libTKXDESTEP.so.7()(64bit) libTKXSBase.so.7()(64bit) libTKernel.so.7()(64bit) libassimp.so.5()(64bit) libc.so.6()(64bit) libf3d.so()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libvtkCommonCore.so.1()(64bit) libvtkCommonDataModel.so.1()(64bit) libvtkCommonExecutionModel.so.1()(64bit) libvtkCommonMath.so.1()(64bit) libvtkCommonSystem.so.1()(64bit) libvtkCommonTransforms.so.1()(64bit) libvtkFiltersCore.so.1()(64bit) libvtkFiltersGeneral.so.1()(64bit) libvtkFiltersGeometry.so.1()(64bit) libvtkIOCityGML.so.1()(64bit) libvtkIOExodus.so.1()(64bit) libvtkIOGeometry.so.1()(64bit) libvtkIOImage.so.1()(64bit) libvtkIOImport.so.1()(64bit) libvtkIOPLY.so.1()(64bit) libvtkIOParallel.so.1()(64bit) libvtkIOXML.so.1()(64bit) libvtkImagingCore.so.1()(64bit) libvtkImagingHybrid.so.1()(64bit) libvtkInteractionStyle.so.1()(64bit) libvtkInteractionWidgets.so.1()(64bit) libvtkRenderingAnnotation.so.1()(64bit) libvtkRenderingCore.so.1()(64bit) libvtkRenderingOpenGL2.so.1()(64bit) libvtkRenderingVolumeOpenGL2.so.1()(64bit) libvtksys.so.1()(64bit) rtld(GNU_HASH) f3d-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) f3d(x86-64) f3d-python3-f3d (rpmlib, GLIBC filtered): f3d(x86-64) libc.so.6()(64bit) libf3d.so()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) rtld(GNU_HASH) f3d-debuginfo (rpmlib, GLIBC filtered): f3d-debugsource (rpmlib, GLIBC filtered): Provides -------- f3d: application() application(f3d-plugin-alembic.desktop) application(f3d-plugin-assimp.desktop) application(f3d-plugin-native.desktop) application(f3d-plugin-occt.desktop) application(f3d.desktop) f3d f3d(x86-64) libf3d-plugin-alembic.so()(64bit) libf3d-plugin-assimp.so()(64bit) libf3d-plugin-exodus.so()(64bit) libf3d-plugin-occt.so()(64bit) libf3d.so()(64bit) metainfo() metainfo(app.f3d.F3D.metainfo.xml) mimehandler(application/dicom) mimehandler(application/gml+xml) mimehandler(application/vnd.3ds) mimehandler(application/vnd.abc) mimehandler(application/vnd.dae) mimehandler(application/vnd.fbx) mimehandler(application/vnd.mhd) mimehandler(application/vnd.nrrd) mimehandler(application/vnd.off) mimehandler(application/vnd.ply) mimehandler(application/vnd.pts) mimehandler(application/vnd.step) mimehandler(application/vnd.vti) mimehandler(application/vnd.vtk) mimehandler(application/vnd.vtm) mimehandler(application/vnd.vtp) mimehandler(application/vnd.vtr) mimehandler(application/vnd.vts) mimehandler(application/vnd.vtu) mimehandler(application/x-tgif) mimehandler(image/vnd.dxf) mimehandler(model/gltf+json) mimehandler(model/gltf-binary) mimehandler(model/iges) mimehandler(model/obj) mimehandler(model/stl) mimehandler(model/vrml) f3d-devel: cmake(f3d) f3d-devel f3d-devel(x86-64) f3d-python3-f3d: f3d-python3 f3d-python3-f3d f3d-python3-f3d(x86-64) f3d-debuginfo: debuginfo(build-id) f3d-debuginfo f3d-debuginfo(x86-64) f3d-debugsource: f3d-debugsource f3d-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2193288 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Haskell, Java, R, PHP, SugarActivity, Ruby, Ocaml, fonts, Python, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Main license seems to be BSD-3-Clause with a few files under MIT license. Is it possible to add a license breakdown in the spec file? b) Can the Java bindings also be built? c) Can files in external directory be obtained from those packaged in Fedora? https://github.com/f3d-app/f3d/blob/master/external/json.hpp https://github.com/f3d-app/f3d/blob/master/external/cxxopts.hpp If not, spec file should indicate they are bundled. d) Building the example may be useful as a basic functionality test e) Please use desktop-file-validate see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_creation f) libraries in main package should have sonames, in particular libf3d, plugin libraries used only internally need not have sonames, but should then be in a subdirectory not in the LD_LIBRARY_PATH g) devel package should have libraries without sonames, see https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/#_libraries https://docs.fedoraproject.org/en-US/packaging-guidelines/#_soname_handling h) Where possible list file extensions used rather than just including an entire directory, for example %files devel %{_includedir}/f3d/*.h %{_libdir}/cmake/f3d/*.cmake %{_libdir}/cmake/f3d/*.in Thanks for your reviewing the package. a) Main license seems to be BSD-3-Clause with a few files under MIT license. Is it possible to add a license breakdown in the spec file? The main license is under BSD-3-Clause license, the external libraries of cxxopts and nlohmann-json are under MIT license. For the testing data, I disable the tests. Do I also need to add the license of the testing data? ref: https://github.com/f3d-app/f3d/blob/master/doc/THIRD_PARTY_LICENSES.md https://github.com/f3d-app/f3d/blob/master/testing/data/DATA_LICENSES.md b) Can the Java bindings also be built? I added build option of the java binding. c) Can files in external directory be obtained from those packaged in Fedora? https://github.com/f3d-app/f3d/blob/master/external/json.hpp https://github.com/f3d-app/f3d/blob/master/external/cxxopts.hpp opened the issue from the upstream repository. https://github.com/f3d-app/f3d/issues/801 d) Building the example may be useful as a basic functionality test I do not see the example building of the source code. e) Please use desktop-file-validate see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_creation added this desktop file validation. f) libraries in main package should have sonames, in particular libf3d, plugin libraries used only internally need not have sonames, but should then be in a subdirectory not in the LD_LIBRARY_PATH g) devel package should have libraries without sonames, see https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/#_libraries https://docs.fedoraproject.org/en-US/packaging-guidelines/#_soname_handling issue: https://github.com/f3d-app/f3d/issues/801 h) Where possible list file extensions used rather than just including an entire directory, for example %files devel %{_includedir}/f3d/*.h %{_libdir}/cmake/f3d/*.cmake %{_libdir}/cmake/f3d/*.in have done this. update: SPEC URL: https://topazus.fedorapeople.org/rpms/f3d.spec SRPM URL: https://topazus.fedorapeople.org/rpms/f3d-2.0.0-1.fc39.src.rpm Created attachment 1963375 [details]
The .spec file difference from Copr build 5875067 to 5897230
Copr build: https://copr.fedorainfracloud.org/coprs/build/5897230 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2193288-f3d/fedora-rawhide-x86_64/05897230-f3d/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Adding soname seems possible: https://github.com/f3d-app/f3d/pull/822 Additional fedora-review messages: - Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation update to 2.1.0 SPEC URL: https://topazus.fedorapeople.org/rpms/f3d.spec SRPM URL: https://topazus.fedorapeople.org/rpms/f3d-2.1.0-1.fc39.src.rpm Created attachment 1974058 [details]
The .spec file difference from Copr build 5897230 to 6142575
Copr build: https://copr.fedorainfracloud.org/coprs/build/6142575 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2193288-f3d/fedora-rawhide-x86_64/06142575-f3d/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |