Bug 2193461

Summary:	CVE-2023-0842 llhttp: node-xml2js: xml2js is vulnerable to prototype pollution [fedora-all]
Product:	[Fedora] Fedora	Reporter:	Patrick Del Bello <pdelbell>
Component:	llhttp	Assignee:	Ben Beasley <code>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	38	CC:	code, jonathan, jstanek, python-packagers-sig, sgallagh, zsvetlik
Target Milestone:	---	Keywords:	Security, SecurityTracking
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-05 17:23:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2193459

Description Patrick Del Bello 2023-05-05 17:16:24 UTC

More information about this security flaw is available in the following bug:

http://bugzilla.redhat.com/show_bug.cgi?id=2193459

Disclaimer: Community trackers are created by Red Hat Product Security team on a best effort basis. Package maintainers are required to ascertain if the flaw indeed affects their package, before starting the update process.

Comment 1 Patrick Del Bello 2023-05-05 17:16:27 UTC

Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# low, medium, high, urgent (required)
severity=medium

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=2193459,2193461

# Description of your update
notes=Security fix for [PUT CVEs HERE]

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

Comment 2 Ben Beasley 2023-05-05 17:23:09 UTC

The llhttp package is a C library, the C sources of which are transpiled from TypeScript. All bundled NodeJS “dev” dependencies belong to the transpilation toolchain. They are used only during the RPM build process to generate C sources from TypeScript. They are not exposed to external input, and they are not included in the binary RPMs. Any NodeJS package security flaws are therefore irrelevant.

Furthermore, the xml2js npm package is not even present in the “dev” dependency bundle. It is only *mentioned* in the “devDependencies” of typescript in node_modules_dev/typescript/package.json.