Bug 2196447

Summary: Should stop installing driver for fwcfg device during v2v converting win2022 and win2019 guests
Product: Red Hat Enterprise Linux 9 Reporter: mxie <mxie>
Component: virt-v2vAssignee: Virtualization Maintenance <virt-maint>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 9.3CC: chhu, hongzliu, juzhou, lersek, rjones, tyan, tzheng, vrozenfe, vwu, xiaodwan
Target Milestone: rcKeywords: Triaged
Target Release: ---Flags: mxie: needinfo? (vrozenfe)
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-11 07:59:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
win10-has-no-fwcfg.png none

Description mxie@redhat.com 2023-05-09 07:58:24 UTC
Created attachment 1963467 [details]
win10-has-no-fwcfg.png

Description of problem:
Should stop installing driver for fwcfg device during v2v converting win2022 and win2019 guests
 
Version-Release number of selected component (if applicable):
virt-v2v-2.3.4-1.el9.x86_64
libguestfs-1.50.1-4.el9.x86_64
guestfs-tools-1.50.1-2.el9.x86_64
nbdkit-server-1.34.1-1.el9.x86_64
libnbd-1.16.0-1.el9.x86_64
virtio-win-1.9.33-0.el9_2.noarch


How reproducible:
100%

Steps to Reproduce:
1.Convert a win2022 and win2019 guest from VMware to local libvirt by virt-v2v
# virt-v2v -ic vpx://root.212.149/data/10.73.212.36/?no_verify=1  -it vddk -io vddk-libdir=/home/vddk8.0.0 -io vddk-thumbprint=D1:03:96:7E:11:3D:7C:4C:B6:50:28:1B:63:74:B5:40:5F:9D:9F:94 -ip /home/passwd  esx8.0-win2022-x86_64 -v -x |& tee > virt-v2v-convert-win2022.log

# virt-v2v -ic vpx://root.212.149/data/10.73.212.36/?no_verify=1  -it vddk -io vddk-libdir=/home/vddk8.0.0 -io vddk-thumbprint=D1:03:96:7E:11:3D:7C:4C:B6:50:28:1B:63:74:B5:40:5F:9D:9F:94 -ip /home/passwd  esx8.0-win2019-x86_64 -v -x |& tee > virt-v2v-convert-win2019.log

2.Power on the guests and found fwcfg device work abnormally, pls refer to screenshots 'win2022-has-bad-fwcfg.png' and 'win2019-has-bad-fwcfg.png'

3.Check qemufwcfg info in v2v-convert-win2022.log, found below info
# cat virt-v2v-convert-win2022.log |grep 'skipping qemufwcfg stub driver in favor of fwcfg driver'
windows: skipping qemufwcfg stub driver in favor of fwcfg driver


Actual results:
As above description

Expected results:
Since fwcfg devices do not work properly in win2022 and win2019 guests after installing drivers, v2v should probably stop installing drivers for fwcfg devices during conversion, just as v2v did for win10 and win11 guests

Additional info:
1. win11 and win10 guests have no fwcfg device after v2v conversion, pls refer to screenshots  'win10-has-no-fwcfg.png' and 'win11-has-no-fwcfg.png'
# virt-v2v -ic vpx://root.212.149/data/10.73.212.36/?no_verify=1  -it vddk -io vddk-libdir=/home/vddk8.0.0 -io vddk-thumbprint=D1:03:96:7E:11:3D:7C:4C:B6:50:28:1B:63:74:B5:40:5F:9D:9F:94 -ip /home/passwd  esx8.0-win11-x86_64 -v -x |& tee > v2v-convert-win11.log

Comment 7 Richard W.M. Jones 2023-05-09 14:24:21 UTC
Thinking is this might be a duplicate of bug 2177673.  Is it fixed if you
install the latest virtio-win?  (Sorry, there's no Fixed-in-version field
in that other bug so I'm not sure what precise version of virtio-win is needed).

Comment 8 mxie@redhat.com 2023-05-10 02:33:22 UTC
(In reply to Richard W.M. Jones from comment #7)
> Thinking is this might be a duplicate of bug 2177673.  Is it fixed if you
> install the latest virtio-win?  (Sorry, there's no Fixed-in-version field
> in that other bug so I'm not sure what precise version of virtio-win is
> needed).

The virtio-win version used in the bug is the latest, this is also my confusion, as I mentioned in the mail, there is still a problem with the fwcfg driver for win2022 and win2019 guests after v2v conversion although the related bugs(2153741, 2151752) have been fixed.

Comment 9 Richard W.M. Jones 2023-05-10 08:42:27 UTC
Hey Vadim, do you know which version of virtio-win is supposed to fix
bug 2177673?

Comment 11 Richard W.M. Jones 2023-05-25 10:08:40 UTC
Setting triaged so I don't keep getting emailed about this.  We're waiting on the
new version of the driver disk to become available so we can test if it fixes things.

Comment 12 John Ferlan 2023-07-10 11:45:17 UTC
Since bug 2177673 is verified for 9.3 and errata for the 9.2.0.z clone bug 2203207 is closed, can you retest this bug against that?

I'm in the process of moving backlog (e.g. virt-maint assigned) bugs to Jira only don't want to move this one if the above fixes things.

Thanks!

Comment 13 mxie@redhat.com 2023-07-11 07:59:07 UTC
(In reply to John Ferlan from comment #12)
> Since bug 2177673 is verified for 9.3 and errata for the 9.2.0.z clone bug
> 2203207 is closed, can you retest this bug against that?
> 
> I'm in the process of moving backlog (e.g. virt-maint assigned) bugs to Jira
> only don't want to move this one if the above fixes things.
> 
> Thanks!

Test the bug with latest builds:
virt-v2v-2.3.4-5.el9.x86_64
virtio-win-1.9.34-0.el9_2.noarch
libvirt-libs-9.5.0-0rc1.1.el9.x86_64
qemu-img-8.0.0-7.el9.x86_64
nbdkit-server-1.34.1-1.el9.x86_64
libnbd-1.16.0-1.el9.x86_64


Test result: 
   
Guest          qemufwcfg driver status after v2v conversion
                  
Win2022        PASS
Win11          PASS
Win10 x64      there is no qemufwcfg device
Win10 x86      there is no qemufwcfg device
Win2019        PASS
Win2016        PASS

The bug has been fixed in virtio-win-1.9.34-0.el9_2.noarch, so I think the bug can be closed as CURRENTRELEASE