Bug 2196748
| Summary: | [cephfs][snap_schedule] "ceph fs snap-schedule status /doesnotexist 1h" throws an exception | ||
|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat Ceph Storage | Reporter: | julpark |
| Component: | CephFS | Assignee: | Milind Changire <mchangir> |
| Status: | CLOSED ERRATA | QA Contact: | julpark |
| Severity: | medium | Docs Contact: | Akash Raj <akraj> |
| Priority: | medium | ||
| Version: | 5.3 | CC: | akraj, ceph-eng-bugs, cephqe-warriors, hyelloji, mchangir, tserlin, vshankar |
| Target Milestone: | --- | ||
| Target Release: | 6.1z1 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ceph-17.2.6-89.el9cp | Doc Type: | Bug Fix |
| Doc Text: |
._snap-schedule_ module no longer throws any traceback
Previously, due to an incorrect subvolume path resolution, traceback was seen on command-line whenever a bad path was provided along with a subvolume argument.
With this fix, users are recommended to ignore the user-specified path for subvolumes and _snap-schedule_ module does not throw any traceback on the command-line interface.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-03 16:45:09 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2221020 | ||
Please specify the severity of this bug. Severity is defined here: https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity. As far as I can tell, we added a changes where the schedule gets deactivated on ENOENT, but adding non-existing file system paths were still allowed. Milind? (In reply to Venky Shankar from comment #2) > As far as I can tell, we added a changes where the schedule gets deactivated > on ENOENT, but adding non-existing file system paths were still allowed. > Milind? Addition of schedules with immediately non-existent paths is a valid operation. The rationale for this feature is that a path can be added which is likely to come into existence in the near future so that the snap scheduling can be started at the desired future START TIME. This specific traceback is due to an attempt to resolve the subvolume path. I think if a subvolume name is not valid then no attempt should be made to resolve it and the available path should just be passed on as is for further processing. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Red Hat Ceph Storage 6.1 Bug Fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2023:4473 The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days |
Description of problem: "ceph fs snap-schedule status /doesnotexist 1h" throws an exception Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. add snap_schedule with specifying time 2. activate it with the dir 3. "ceph fs snap-schedule status /path 1h" Actual results: [root@ceph-julpark-k18qvo-node7 cephuser]# ceph fs snap-schedule status /doesnotexist 1h Error EINVAL: Traceback (most recent call last): File "/usr/share/ceph/mgr/mgr_module.py", line 1448, in _handle_command return CLICommand.COMMANDS[cmd['prefix']].call(self, cmd, inbuf) File "/usr/share/ceph/mgr/mgr_module.py", line 414, in call return self.func(mgr, **kwargs) File "/usr/share/ceph/mgr/snap_schedule/module.py", line 84, in snap_schedule_get abs_path = self.resolve_subvolume_path(use_fs, subvol, path) File "/usr/share/ceph/mgr/snap_schedule/module.py", line 47, in resolve_subvolume_path raise Exception(f'Could not resolve {path} in {fs}, {subvol}') Exception: Could not resolve /doesnotexist in cephfs, 1h Expected results: Exception should not be there Additional info: