Bug 219869 (perldap)
| Summary: | Review Request: perl-Mozilla-LDAP | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rich Megginson <rmeggins> | ||||
| Component: | Package Review | Assignee: | Dennis Gilmore <dennis> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | dennis, jarod, opensource | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-01-10 23:57:50 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 196401 | ||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Rich Megginson
2006-12-15 20:02:37 UTC
a couple of notes this builds and works fine on sparc not sure why its ExclusiveArch i386 x86_64 the Requires on nss nspr and mozldap are unneccesary rpm has the smarts to know that source needs to be a full url in spec file please add disttag to the release rpmlint says E: perl-Mozilla-LDAP useless-explicit-provides perl(Mozilla::LDAP::Entry) E: perl-Mozilla-LDAP non-standard-executable-perm /usr/lib/perl5/vendor_perl/5.8.8/sparc-linux-thread-multi/auto/Mozilla/LDAP/API/API.so 0555 E: perl-Mozilla-LDAP zero-length /usr/lib/perl5/vendor_perl/5.8.8/sparc-linux-thread-multi/auto/Mozilla/LDAP/API/API.bs Thanks Dennis. Here are the new files: SPEC URL: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-Mozilla-LDAP.spec SRPM URL: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-Mozilla-LDAP-1.5-7.src.rpm Sources: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-mozldap-1.5.tar.gz ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/Makefile.PL.rpm I made a separate Makefile.PL.rpm so as not to conflict with the other Makefile.PL Created attachment 145292 [details]
updated spec file
Two small issues
include MPL-1.1.txt RELEASE in %doc and change the license field to MPL as
thats what it seems to be licensed under.
package meets naming and packaging guidelines.
specfile is properly named, is cleanly written and uses macros consistently.
dist tag is present.
build root is correct.
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
license is open source-compatible. MPL License text included in package.
source files match upstream:
136f74d7649ada77cdf7657bb01a165f perl-mozldap-1.5.tar.gz
136f74d7649ada77cdf7657bb01a165f ../SOURCES/perl-mozldap-1.5.tar.gz
latest version is being packaged.
BuildRequires are proper.
package builds in mock ( on FC-6 ).
rpmlint is silent.
final provides and requires are sane:
no shared libraries are present.
package is not relocatable.
owns the directories it creates.
doesn't own any directories it shouldn't.
no duplicates in %files.
file permissions are appropriate.
%clean is present.
no scriptlets present.
code, not content.
documentation is small, so no -docs subpackage is necessary.
%docs are not necessary for the proper functioning of the package.
no headers.
no pkgconfig files.
no libtool .la droppings.
not a GUI app.
not a web app.
APPROVED using the attached spec file which fixes the issues
Thanks Dennis. Here are the final versions for inclusion into Fedora: SPEC URL: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-Mozilla-LDAP.spec SRPM URL: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-Mozilla-LDAP-1.5-8.src.rpm Sources: ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/perl-mozldap-1.5.tar.gz ftp://ftp.mozilla.org/pub/mozilla.org/directory/perldap/releases/1.5/src/Makefile.PL.rpm FE-ACCEPT should be blocked, not being depended on. |