Bug 219931

Summary:	Review Request: perl-Net-GPSD - Provides an object client interface to the gpsd server daemon
Product:	[Fedora] Fedora	Reporter:	Jose Pedro Oliveira <jose.p.oliveira.oss>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-12-22 12:15:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Jose Pedro Oliveira 2006-12-17 00:10:45 UTC

Spec URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-Net-GPSD.spec

SRPM URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-Net-GPSD-0.32-1.src.rpm

Description:
Net::GPSD provides an object client interface to the gpsd server daemon.
gpsd is an open source GPS deamon from http://gpsd.berlios.de/.

Comment 1 Parag AN(पराग) 2006-12-18 04:44:17 UTC

rpmlint is silent
W: perl-Net-GPSD spelling-error-in-description deamon daemon
You made a misspelling in the Description. Please double-check.

But you can correct it while importing package.

Comment 2 Parag AN(पराग) 2006-12-18 04:46:58 UTC

(In reply to comment #1)
> rpmlint is silent
oops rpmlint is NOT silent

> W: perl-Net-GPSD spelling-error-in-description deamon daemon
> You made a misspelling in the Description. Please double-check.
> 
> But you can correct it while importing package.

Comment 3 Parag AN(पराग) 2006-12-18 04:47:29 UTC

Review:
+ package builds in mock (development i386).
- rpmlint is NOT silent for SRPM and for RPMS but not affecting other packages.
W: perl-Net-GPSD spelling-error-in-description deamon daemon
You made a misspelling in the Description. Please double-check.

+ source files match upstream.
7869c7d1cc20a37e70b3ea5a0c546bc7  Net-GPSD-0.32.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ %check used 
make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/base....ok
All tests successful.
Files=1, Tests=45,  0 wallclock secs ( 0.08 cusr +  0.01 csys =  0.09 CPU)

+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Followed perl packaging guidelines.
APPROVED.

Kindly change spelling in SPEC before you will import this package.

Comment 4 Jose Pedro Oliveira 2006-12-22 12:15:12 UTC

Thanks for the review.

Package imported and built for FC-5, FC-6, and devel (with the typo corrected).