Bug 219979 (perl-Text-ASCIITable)
| Summary: | Review Request: perl-Text-ASCIITable - Create a nice formatted table using ASCII characters | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lkundrak |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | gwync:
fedora-cvs+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Text-ASCIITable/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-12-18 05:35:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Chris Weyl
2006-12-18 02:24:18 UTC
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMS. + source files match upstream. 25fea1cef17be49a6da1d9b5267fba97 Text-ASCIITable-0.18.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + %check used make test + ./Build test t/01_default........ok t/02_custom.........ok t/03_options........ok t/04_multiline......ok t/05_wordwrap.......ok t/06_htmlstrip......ok t/07_aligning.......ok t/08_heading........ok t/09_ansistrip......ok t/10_pages..........ok t/11_overloading....ok t/12_chaining.......ok All tests successful. Files=12, Tests=105, 1 wallclock secs ( 0.24 cusr + 0.07 csys = 0.31 CPU) + Provides: perl(Text::ASCIITable) = 0.18 perl(Text::ASCIITable::Wrap) = 0.2 + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Dose owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED. Imported and building for devel; branches requested. Thanks for the review! :) Imported and building for devel; branches requested. Thanks for the review! :) Slipped with the mouse there; should be to where things should be now :) Chris: I'll be very thankful if this was in EPEL-5 as well. Could you please request an EL-5 branch (I'd gladly do that if you have a reason for not maintaining it there). Thanks! Package Change Request ====================== Package Name: perl-Text-ASCIITable New Branches: epel7 Owners: lkundrak InitialCC: perl-sig The Fedora maintainer is unfortunately not maintaining EPEL packages: http://fedoraproject.org/wiki/EPEL/ContributorStatusNo Git done (by process-git-requests). |