Bug 220218
| Summary: | Review Request: perl-Module-Find - Find and use installed modules in a (sub)category | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cweyl, mbooth, paul, rjones, tremble |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-12-22 12:12:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Jose Pedro Oliveira
2006-12-19 19:26:11 UTC
will review this Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMS. + source files match upstream. 1b756c84e476fc8179fcf2699a4d1a86 Module-Find-0.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + %check used PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/1-use..............ok t/2-find.............ok t/3-usesub...........ok t/4-useall...........ok t/5-setmoduledirs....ok t/pod-coverage.......ok t/pod................ok All tests successful. Files=7, Tests=26, 1 wallclock secs ( 0.43 cusr + 0.12 csys = 0.55 CPU) + Provides: perl(Module::Find) = 0.05 + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Dose owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED. Thanks for the review. Package imported and built for FC-5, FC-6, and devel. Package Change Request ====================== Package Name: perl-Module-Find New Branches: EL-5 Owners: I would like to add virt-v2v to EL-5, which has a dependency on perl-Module-Find. We need an ack from the current owner beforce branching their packages for EPEL. Have you read https://fedoraproject.org/wiki/Getting_a_Fedora_package_in_EPEL? Ack! EPEL branch here is a-ok, so long as the requester takes ownership of the new branches. Since Owners: is empty above, I'm stull not sure what to do. Matt, Chris has indicated that you should be the owner of the EPEL branch. If that's what you want, please submit a new CVS request with your FAS ID in the Owners: field. Matt, you should own this one I think. Package Change Request ====================== Package Name: perl-Module-Find New Branches: EL-5 Owners: mdbooth I'm happy to take ownership of this branch. CVS done. Package Change Request ====================== Package Name: perl-HTML-Format New Branches: EL-6 Owners: tremble No response from owner, and it's going to be tied to EL-6 SRPMs anyway... https://bugzilla.redhat.com/show_bug.cgi?id=610094 Sorry that should have been https://bugzilla.redhat.com/show_bug.cgi?id=612418 spot seems to already own a EL-6 branch here. Package Change Request ====================== Package Name: perl-Module-Find New Branches: EL-6 Owners: tremble No response from owner, and it's going to be tied to EL-6 SRPMs anyway... CVS done (by process-cvs-requests.py). |