Bug 2203278

Summary: [4.12] Snapshot clone doesn't handle CSI drivers that have 0 in restoreSize of a snapshot properly
Product: Container Native Virtualization (CNV) Reporter: Alexander Wels <awels>
Component: StorageAssignee: Alexander Wels <awels>
Status: CLOSED CURRENTRELEASE QA Contact: dalia <dafrank>
Severity: high Docs Contact:
Priority: high    
Version: 4.12.5CC: alitke, ngavrilo, yadu
Target Milestone: ---   
Target Release: 4.12.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2203279 (view as bug list) Environment:
Last Closed: 2023-06-27 16:57:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2203279    

Description Alexander Wels 2023-05-11 17:51:01 UTC 
Description of problem:
When doing a snapshot clone, the part of the code that creates a PVC with the snapshot source currently relies on the restoreSize of the VolumeSnapshot. If this value is 0 then creating the PVC fails (because we are attempting to create a 0 size PVC). For various reasons it might not be feasible to get a proper value in this field by the driver. See: democratic-csi/democratic-csi#129 We do know ahead of time what we want the size of the PVC to be, but due to some older broken CSI drivers we had to start at the restoreSize and then expand to the target size.

If we consider that behavior (target PVC size must equal restore size) a bug in the CSI driver, then we can create a PVC of the requested size regardless of the restoreSize in the snapshot.

Version-Release number of selected component (if applicable):


How reproducible:
Use a CSI driver that has this issue (like the democratic-csi, or dell storage). 

Steps to Reproduce:
1. Try to create a snapshot clone
2. Clone will remain stuck in snapshot in progress.
3.

Actual results:
No clone happens

Expected results:
Clone happens normally even with storage where the restoreSize of the snapshot is 0.

Additional info: