Bug 2203543

Summary: Add dependency on ffmpeg-free or ffmpeg?
Product: [Fedora] Fedora Reporter: xspielinbox+redhat
Component: youtube-dlAssignee: Till Maas <opensource>
Status: ON_QA --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 38CC: david08741, james, kwizart, opensource, tim
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description xspielinbox+redhat 2023-05-13 20:40:50 UTC
Description of problem:
When installing youtube-dl neither ffmpeg nor ffmpeg-free get's installed automatically and most features therefore don't work and the user has to figure out the relevant package to install manually.

Version-Release number of selected component (if applicable):
2021.12.17-5.fc38

How reproducible:
try to download an audio from YouTube Music with '-x' flag.

Steps to Reproduce:
1. sudo dnf install youtubed-dl
2. youtube-dl -x https://music.youtube.com/watch?v=qYj5efAqrI8

Actual results:
WARNING: qYj5efAqrI8: writing DASH m4a. Only some players support this container. Install ffmpeg or avconv to fix this automatically.
ERROR: ffprobe/avprobe and ffmpeg/avconv not found. Please install one.

Expected results:
It automatically results in some audio-file.

Additional info:
ffmpeg is only part of RPM Fusion, only ffmpeg-free is part of Fedora and that conflicts with ffmpeg. Avconv does not seem to be packaged for Fedora Linux at all.

My question/enhancement proposal would be, whether it would be possible to depend on either ffmpeg or ffmpeg-free (whereby I mean, that ffmpeg-free as well as ffmpeg would fulfill the dependency, but at least one would always be ensured as installed by dnf).

Comment 1 david08741 2023-05-13 22:39:31 UTC
A (soft) dependency on /usr/bin/ffmpeg could be added.

See however https://bugzilla.redhat.com/show_bug.cgi?id=2203137#c2

Comment 2 xspielinbox+redhat 2023-05-14 21:19:08 UTC
> A (soft) dependency on /usr/bin/ffmpeg could be added.
What effect would this have? What would speak against that?

> See however https://bugzilla.redhat.com/show_bug.cgi?id=2203137#c2
So you discourage / don't recommend the further usage of youtube-dl and would recommend yt-dlp instead?
Is this issue too fixed/not applicable in yt-dlp?

Comment 3 david08741 2023-05-15 14:56:06 UTC
(In reply to xspielinbox+redhat from comment #2)
> > A (soft) dependency on /usr/bin/ffmpeg could be added.
> What effect would this have?

Unless weak dependencies are disabled, that would pull in ffmpeg or ffmpeg-free.

> What would speak against that?

It need to be done ... purely lack of time on my side, sorry.

> > See however https://bugzilla.redhat.com/show_bug.cgi?id=2203137#c2
> So you discourage / don't recommend the further usage of youtube-dl and
> would recommend yt-dlp instead?

Yes, youtube-dl is somewhat dead upstream (at least no new releases) so I want to remove youtube-dl and instead have yt-dlp provide youtube-dl. However, I didn't get to it yet ...

> Is this issue too fixed/not applicable in yt-dlp?

This is fixed in yt-dlp, it already pulls in ffmpeg and ffprobe as weak dependency.

Comment 4 xspielinbox+redhat 2023-05-15 16:11:15 UTC
> Unless weak dependencies are disabled, that would pull in ffmpeg or ffmpeg-free.
Ok, sound's great.

> Yes, youtube-dl is somewhat dead upstream (at least no new releases) so I want to remove youtube-dl and instead have yt-dlp provide youtube-dl. However, I didn't get to it yet ...
Ok, good to know. Then I'll switch.

> This is fixed in yt-dlp, it already pulls in ffmpeg and ffprobe as weak dependency.
Great!

> It need to be done ... purely lack of time on my side, sorry.
Given the circumstances, it would be ok for me if you don't fix/resolve this minor issue for youtube-dl is already legacy.
You may close this issue, though I don't know what the correct resolution would be.

Comment 5 Nicolas Chauvet (kwizart) 2023-06-20 08:15:11 UTC
I've suggested to the ffmpeg-free maintainer to use a virtual provide such as ffmpeg-bin that would be implemented both sides.

Comment 6 Fedora Update System 2023-08-16 07:23:03 UTC
FEDORA-2023-1f11546a48 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1f11546a48

Comment 7 Fedora Update System 2023-08-16 07:23:13 UTC
FEDORA-2023-5435c10480 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5435c10480

Comment 8 xspielinbox+redhat 2023-08-16 14:53:14 UTC
Thank you for fixing it even though youtube-dl is legacy!

Comment 9 Fedora Update System 2023-08-17 01:30:16 UTC
FEDORA-2023-1f11546a48 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-1f11546a48`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-1f11546a48

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-08-17 01:32:08 UTC
FEDORA-2023-5435c10480 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5435c10480`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5435c10480

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.