Bug 2203544

After seeing and using the .spec file, it seems some dependencies are missing. Maybe use the %pyproject-related macros will be better.

ref:: https://github.com/Quansight-Labs/ndindex/blob/662648cad0f2f75ebdf17346c7450b023a92b324/setup.py#L60-L64
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Automatically-generated-dependencies
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python

Indeed, numpy was missing from the list. I fixed this and also switch to %pytest
macro in %check. Updated in place.

I tried to convert to %pyproject_buildrequires/%pyproject_install/…, but it doesn't
work of out of the box, and I think fixing all the issues would be more trouble
than its worth:
- %pyproject_buildrequires doesn't pick up pytest for some reason, with or without -w
- some compiled files are not installed properly
I reverted back to %py3_build/%py3_install, which seems much more robust.
I tested with a clean mock chroot, so the forgotten BRs are fixed, and if
something more is needed in the future, it'll be easy to fix. This project is unlikely
to change deps often.

Could you please report the problems to the python-devel list, so I could have a look and see if we need to fix something in the macros?

This is my spec file: https://in.waw.pl/~zbyszek/fedora/python-ndindex.pyproject.spec
The first build fails because pytest is not installed.
I then install python3-pytest manually, and it fails because python3-hypothesis is missing.
After that, the tests pass, and the failure is:
error: Empty %files file /builddir/build/BUILD/ndindex-1.7/debugsourcefiles.list
Oh, that is because it's also missing python3-Cython.
Once that is also installed, the package is generated correctly.

If you think it's worth forwarding to python-devel, please do so.
But it's also likely that I messed something up.

404 Not Found

The link in comment#4 is wrong and is getting fedora-review to fail.

Spec URL: https://in.waw.pl/~zbyszek/fedora/python-ndindex.spec
SRPM URL: https://in.waw.pl/~zbyszek/fedora/python-ndindex-1.7-1.fc39.src.rpm

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== Issues =====
- Check license tag, at least one source file is BSD licensed
- Check rpmlint error about line too long in specfile


===== MUST items =====

C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License", "*No copyright* Public domain", "BSD 3-Clause License",
     "Python Software Foundation License 2.0". 93 files have unknown
     license. Detailed output of licensecheck in
     /home/rpmbuild/reviews/2203544-python-ndindex/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-ndindex
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: python3-ndindex-1.7-1.fc39.x86_64.rpm
          python-ndindex-debugsource-1.7-1.fc39.x86_64.rpm
          python-ndindex-1.7-1.fc39.src.rpm
==================================== rpmlint session starts ===================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp4v6ddh5b')]
checks: 31, packages: 3

python-ndindex.src: W: strange-permission python-ndindex.spec 600
python-ndindex.src: E: description-line-too-long objects, match semantics of numpy's ndarray, and to provide useful transformation
python3-ndindex.x86_64: E: description-line-too-long objects, match semantics of numpy's ndarray, and to provide useful transformation
===== 3 packages and 0 specfiles checked; 2 errors, 1 warnings, 2 badness; has taken 1.1 s ====




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 2

python3-ndindex.x86_64: E: description-line-too-long objects, match semantics of numpy's ndarray, and to provide useful transformation
 2 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 0.5 s 



Unversioned so-files
--------------------
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/__init__.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/_crt.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/_version.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/array.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/booleanarray.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/chunking.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/ellipsis.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/integer.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/integerarray.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/ndindex.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/newaxis.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/shapetools.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/slice.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/subindex_helpers.cpython-311-x86_64-linux-gnu.so
python3-ndindex: /usr/lib64/python3.11/site-packages/ndindex/tuple.cpython-311-x86_64-linux-gnu.so

Source checksums
----------------
https://github.com/quansight-labs/ndindex/archive/1.7/python-ndindex-1.7.tar.gz :
  CHECKSUM(SHA256) this package     : 388f45290393262b69ee440053bfe1664cdac6a125b29c2ea2569cdc3943dbbe
  CHECKSUM(SHA256) upstream package : 388f45290393262b69ee440053bfe1664cdac6a125b29c2ea2569cdc3943dbbe


Requires
--------
python3-ndindex (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    python(abi)
    python3-numpy
    rtld(GNU_HASH)

python-ndindex-debugsource (rpmlib, GLIBC filtered):



Provides
--------
python3-ndindex:
    python-ndindex
    python3-ndindex
    python3-ndindex(x86-64)
    python3.11-ndindex
    python3.11dist(ndindex)
    python3dist(ndindex)

python-ndindex-debugsource:
    python-ndindex-debugsource
    python-ndindex-debugsource(x86-64)



Diff spec file in url and in SRPM
---------------------------------
--- /home/rpmbuild/reviews/2203544-python-ndindex/srpm/python-ndindex.spec	2023-05-19 09:35:26.505279083 +0200
+++ /home/rpmbuild/reviews/2203544-python-ndindex/srpm-unpacked/python-ndindex.spec	2023-05-14 15:53:10.000000000 +0200
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.3.5)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 Name:           python-ndindex
 Version:        1.7
@@ -60,3 +70,4 @@
 
 %changelog
-%autochangelog
+* Sun May 14 2023 Zbigniew Jędrzejewski-Szmek <zbyszek.pl> - 1.7-1
+- First working version


Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2203544
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: Java, R, Perl, PHP, SugarActivity, Haskell, C/C++, fonts, Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

> https://in.waw.pl/~zbyszek/fedora/python-ndindex.pyproject.spec
Oops. I don't know what went wrong there. It is fixed now.

> - Check license tag, at least one source file is BSD licensed
> - Check rpmlint error about line too long in specfile
Both fixed. I added a "license breakdown" comment in the spec file.


Spec URL: https://in.waw.pl/~zbyszek/fedora/python-ndindex.spec
SRPM URL: https://in.waw.pl/~zbyszek/fedora/python-ndindex-1.7-2.fc39.src.rpm

(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> This is my spec file:
> https://in.waw.pl/~zbyszek/fedora/python-ndindex.pyproject.spec
> The first build fails because pytest is not installed.

There is no information whenever in the spec that would instruct RPM to install pytest.
Upstream lists it in setup.py tests_require only: https://github.com/Quansight-Labs/ndindex/blob/1.7/setup.py#L60
This is not supported by our macros and generally is a deprecated way of specifying tests deps upstream. I'd suggest a [test] extra upstream or BR pytest manually if upstream involvement would be too much to ask.

> I then install python3-pytest manually, and it fails because
> python3-hypothesis is missing.

Same.

> After that, the tests pass, and the failure is:
> error: Empty %files file
> /builddir/build/BUILD/ndindex-1.7/debugsourcefiles.list
> Oh, that is because it's also missing python3-Cython.

Upstream dos not list Cython dependency at all. I'd suggest listing it in pyproject.toml (which upstream dos not yet have) or BR it manually.

> Once that is also installed, the package is generated correctly.

Miro, thanks for looking. As I suspected, using %pyproject macros would require
fixing up the metadata. At this point, I prefer to use the older method, since
it works reliably and I don't see a strong benefit from the newer one. If upstream
fixes the metadata, it'll make sense to switch.

Looks good now, package approved!

BTW Cython seems completely optional dependency as there is a 'check_cython()' method in setup.py, so I don't think upstream would add it as a hard dependency.

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ndindex

Thank you for the review!

Built for all releases.

I had two disable some tests on F37 which has older hypothesis, and I added ExcludeArch:i686.
There's some index overflow on 32 bit and I don't think it's useful to try to figure this out.