Bug 220356

Summary:

booty does not persists certain kernel params

Product:

Red Hat Enterprise Linux 4

Reporter:

Guil Barros <gbarros>

Component:

booty

Assignee:

Peter Jones <pjones>

Status:

CLOSED ERRATA

QA Contact:

Robert M Williams <rwilliam>

Severity:

medium

Docs Contact:

Priority:

high

Version:

4.0

CC:

atodorov, tao

Target Milestone:

---

Keywords:

EasyFix, HardwareEnablement, Patch

Target Release:

---

Hardware:

All

OS:

Linux

Whiteboard:

Fixed In Version:

RHBA-2008-0681

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2008-07-24 19:35:11 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Attachments:

Description	Flags
patch to bootloaderInfo.py in booty-0.31.2-1.i386.rpm	none
patch to bootloaderInfo.py in booty-0.44.4-1.i386.rpm	none
patch to bootloaderInfo.py in booty-0.80-1.i386.rpm	none
patch to bootloaderInfo.py in booty-0.44.4-1.i386.rpm	none
patch to bootloaderInfo.py in booty-0.80-1.i386.rpm	none
patch to bootloaderInfo.py in booty-0.31.2-1.i386.rpm	none

Description Guil Barros 2006-12-20 17:12:38 UTC

Description of problem:
booty is reponsible for adding kernel params used during install into grub.conf
but it does not do so for all params. Specifically "clock=", "pci=", and
"console=" are useful ones that should arguably persist.

Version-Release number of selected component (if applicable):
All pre-0.8 for "pci=". All for others.

  
Actual results:
"clock=", "pci=", and "console=" do not get added to grub.conf after install

Expected results:
They should be copied over from syslinux at install-time.

Additional info:
"pci=nommconf" is required for a number of AMD hardware to run correctly, and as
such should persist.

"clock=" is required to make sure vmware virtual machines pick the correct
timer, and so that the correct timer is used on certain AMD hardware. In RHEL4
it correctly picks HPET if available, default is TSC. VMWare virtual machines
should use PIT to avoid excessive clock skew.

"console=" seems to persist in RHEL4 but not in RHEL3, yet it is not listed in
booty:ourargs.

Comment 1 Guil Barros 2006-12-21 14:56:27 UTC

Created attachment 144185 [details]
patch to bootloaderInfo.py in booty-0.31.2-1.i386.rpm

Comment 2 Guil Barros 2006-12-21 15:12:40 UTC

Created attachment 144190 [details]
patch to bootloaderInfo.py in booty-0.44.4-1.i386.rpm

Comment 3 Guil Barros 2006-12-21 15:13:48 UTC

Created attachment 144191 [details]
patch to bootloaderInfo.py in booty-0.80-1.i386.rpm

Comment 6 Peter Jones 2007-12-11 18:10:12 UTC

The patch here isn't really correct, in that "console=" is already handled,
though through a different mechanism due to its use of multiple arguments in
combination and their effect on the install process itself.  See the
BootloaderInfo class's __init__ method and then later the use of
self.serialDevice in the writeGrub method.  Adding specific arguments related to
console needs to be done in that code rather than with "ourargs".

Comment 8 Guil Barros 2007-12-12 21:12:31 UTC

Created attachment 286171 [details]
patch to bootloaderInfo.py in booty-0.44.4-1.i386.rpm

updated original patch to remove reference to "console=" as per comment.

Comment 9 Guil Barros 2007-12-12 21:13:41 UTC

Created attachment 286181 [details]
patch to bootloaderInfo.py in booty-0.80-1.i386.rpm

updated original patch to remove reference to "console=" as per comment.

Comment 10 Guil Barros 2007-12-12 21:50:01 UTC

Created attachment 286221 [details]
patch to bootloaderInfo.py in booty-0.31.2-1.i386.rpm

updated to remove "console="

Comment 11 Peter Jones 2008-02-12 20:38:12 UTC

Fixed in booty-0.44.7-1 .

Comment 12 Peter Jones 2008-02-14 21:00:09 UTC

Actually, it'll be 0.44.8-1 .

Comment 14 Alexander Todorov 2008-06-06 09:41:45 UTC

Guil,
fix for this should be available in RHEL4-U7 snapshot #2. Please work with the
customer to verify that the bug has been fixed. Please post you comments to this
bug.

Thanks.

Comment 15 Robert M Williams 2008-06-06 16:38:45 UTC

verified fixed in rhel4-u7 snapshot 2

Comment 17 errata-xmlrpc 2008-07-24 19:35:11 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2008-0681.html