Bug 2204461

Summary:	Adjust rsync options in DVM
Product:	Migration Toolkit for Containers	Reporter:	Jason Montleon <jmontleo>
Component:	Controller	Assignee:	Jason Montleon <jmontleo>
Status:	CLOSED ERRATA	QA Contact:	mohamed <midays>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.7.9	CC:	dymurray, gscheffe, midays, rjohnson
Target Milestone:	---
Target Release:	1.7.10
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-06-15 09:48:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jason Montleon 2023-05-15 15:32:56 UTC

Description of problem:
After discussion we want to remove the hard coded munge links option in rsync for DVM transfer, as we think it may lead to undesired behavior in at least some occasions.

As the goal is also to transfer singular volumes we would also like to add the -x option to ensure we don't transfer data from other mounts.

Version-Release number of selected component (if applicable):
1.7.9

Comment 1 Dylan Murray 2023-05-17 01:27:29 UTC

I was able to get this working setting `migration_rsync_privileged: true` as well as testing a version of crane-lib that sets on the rsync server config:

```
use chroot = yes
munge symlinks = no
```

Seems like this should preserve the symlinks as is, will likely want to make both of these options configurable.

Comment 3 Dylan Murray 2023-05-24 12:38:06 UTC

https://github.com/migtools/mig-controller/commit/95eeff7f37af33e4b8469fe5e45f2f4af4c73893

Comment 7 mohamed 2023-06-01 15:15:23 UTC

Verified using MTC 1.7.10
symbolic links are migrated as expected

in Source cluster:

[midays@fedora ~]$ oc exec -it -n migration-options test-pod -c test-container -- ls -l /test-volume
total 0
lrwxrwxrwx    1 root     root            10 Jun  1 14:55 test-link -> /test-file


in target cluster:

[midays@fedora crane-ui-tests]$ oc exec -it -n migration-options test-pod -c test-container -- ls -l /test-volume
total 0
lrwxrwxrwx    1 root     root            10 Jun  1 14:55 test-link -> /test-file

Comment 11 errata-xmlrpc 2023-06-15 09:48:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Migration Toolkit for Containers (MTC) 1.7.10 security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:3624