Bug 220525
| Summary: | not all enslaved devices are removed in 'ifdown bond0' | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Andy Gospodarek <agospoda> | ||||||||||||||
| Component: | initscripts | Assignee: | Bill Nottingham <notting> | ||||||||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Brock Organ <borgan> | ||||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||||
| Priority: | medium | ||||||||||||||||
| Version: | 5.0 | CC: | peterm, rvokal | ||||||||||||||
| Target Milestone: | --- | Keywords: | Regression | ||||||||||||||
| Target Release: | --- | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | Linux | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Fixed In Version: | RC | Doc Type: | Bug Fix | ||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||
| Last Closed: | 2007-02-08 01:58:51 UTC | Type: | --- | ||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||
| Embargoed: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Andy Gospodarek
2006-12-21 22:07:32 UTC
Created attachment 144225 [details]
possible patch
quick patch that worked for me
Created attachment 144226 [details]
ifdown failure debug
Created attachment 144227 [details]
ifdown debug with attached patch
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. Created attachment 144847 [details]
shorter diff
Here's a shorter diff that works for me - does it work for you?
Note that without this, just doing (for example) 'ifdown eth1' will fail too.
I'll test it tomorrow morning to be sure, but I like it. Created attachment 144848 [details]
better patch
This makes it abundantly clear what we're doing here, at the expense of
breaking indentation.
Created attachment 144849 [details]
patch. tested!
Whoops.
Does that work when the MAC gets changed since the bond gives each slave it's MAC? That was the original reason why the old check wasn't working on my system. Basically, what it does is skip the MAC check entirely when bringing down any interface that's a bonding slave (has SLAVE set to 'yes' and has a MASTER set.) The only situation where something odd could happen is if you have slaves that aren't actually defined in the configuration as such - of course, that case can't really work right anyway (and is somewhat nonsensical.) Raising as blocker, since it's a regression. Short summary: detaching bond slaves whether via 'ifdown <bonding device>' or 'ifdown <slave device>' doesn't work right. Patch has been tested and resolves it for the reproducer provided. Risk to non-bonding configurations: none. Risk to bonding configurations: should be none - at worst, a case that's already broken may still be broken. Built in 8.45.13.EL-1. QE ack for RHEL5. A package has been built which should help the problem described in this bug report. This report is therefore being closed with a resolution of CURRENTRELEASE. You may reopen this bug report if the solution does not work for you. |