Bug 220533

Summary: units: non-failsafe install-info usage, info files removed from index on update
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: unitsAssignee: Harald Hoyer <harald>
Status: CLOSED RAWHIDE QA Contact: Ben Levenson <benl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: laroche
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-01-24 09:38:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Dpm none

Description Ville Skyttä 2006-12-21 22:32:03 UTC 
units's install-info usage is not failsafe, see
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#info

Additionally, the install-info --delete in %preun should be wrapped inside "if
[ $1 -eq 0 ]" to prevent the info files from being removed from the index on
upgrades.
Comment 1 Florian La Roche 2007-01-23 13:47:12 UTC 
Fixed in -2.

Thanks,

Florian La Roche
Comment 2 Ville Skyttä 2007-01-23 16:54:43 UTC 
Created attachment 146317 [details]
Dpm

Oops, -2 wraps %post inside [ "$1" = 0 ], that can never happen and should be
in %preun instead, fix attached.
Comment 3 Ville Skyttä 2007-01-23 16:57:27 UTC 
In case you're wondering, the "Dpm" in the patch description in comment 2 is
just an odd way of saying "fix info removal from index" ;) (accidental Enter hit
while looking for backspace)
Comment 4 Harald Hoyer 2007-01-24 09:38:57 UTC 
fixed previous fix