Bug 220649
| Summary: | NFS with Kerberos completely broken on 2.6.18 and 2.6.19 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Paarvai Naai <opensource3141> | ||||||||
| Component: | kernel | Assignee: | Steve Dickson <steved> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Brian Brock <bbrock> | ||||||||
| Severity: | urgent | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 5.0 | CC: | coughlan, dzickus, francois.marabelle, jburke, jlaska, jturner, k.georgiou, rkenna, staubach, wtogami | ||||||||
| Target Milestone: | --- | Keywords: | Regression | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | RC | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2007-02-08 02:01:01 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Paarvai Naai
2006-12-22 18:58:15 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. This bugzilla has Keywords: Regression. Since no regressions are allowed between releases, it is also being proposed as a blocker for this release. Please resolve ASAP. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Created attachment 146024 [details]
Purposed Patch
This is patch is a backport of the following upstream commit:
commit 3e32a5d99a467b9d4d416323c8c292479b4915e5
Author: Trond Myklebust <Trond.Myklebust>
Date: Thu Nov 16 11:37:27 2006 -0500
SUNRPC: Give cloned RPC clients their own rpc_pipefs directory
Signed-off-by: Trond Myklebust <Trond.Myklebust>
There also so some changes needed to the cloning process that
were needed to stop memory corruption (that has existed since
the beginning)....
Created attachment 146027 [details]
The complete patch
Do we have any test results using this patch that show normal nfs and nfs+krb5 test results? Created attachment 146187 [details]
Updated patch that combines two other upstream patches
It turns out the previous posted patch breaks UDP mounts.
So I decided to back port the following upstream patch that adds refs
counts to cloned connections:
commit 6b6ca86b77b62b798cf9ca2599036420abce7796
Author: Trond Myklebust <Trond.Myklebust>
Date: Tue Sep 5 12:55:57 2006 -0400
SUNRPC: Add refcounting to the struct rpc_xprt
In a subsequent patch, this will allow the portmapper to take a reference
to the rpc_xprt for which it is updating the port number, fixing an Oops.
Then it turned out a third upstream patch was also needed to avoid
a BUG_ON() from popping in a "valid" error path...
> Do we have any test results using this patch that show normal nfs and nfs+krb5
> test results?
Yes... Jeff Burke ran some RHTS tests over the weekend to ensure there
were no regressions and will continue to run the tests...
How much testing have we don't on the krb functionality? Also, are we really sure that the only way to rememdy this regression is bringing in new functionality? > How much testing have we don't on the krb functionality? I'll assume s/don't/done/.... And the answer to that question is none that I'm aware of... except for the unit testing I do for each release... That's how we got into this position... We also don't test simultaneously NFS mounts... > Also, are we really sure that the only way to rememdy this > regression is bringing in new functionality? We are not bring in new functionality, secure mounts have been around since RHEL4... and I know a growing number people are using this feature due to the increasing number of bugs... Yep, was supposed to be "done" . . . as for the "new functionality" comment, what I meant the fact the patch adds ref counting to cloned connections. Looks like we've got no option here. The change breaks kABI, so best to get it into the mix before GA. Thanks for all of the activity since my initial report of this bug. I just wanted to remind you folks not to forget about FC5/FC6 kernel updates for us Fedora users out there. I filed this bug in both under both of those distros as well, but recently saw that FC6 released a version of 2.6.19 that doesn't seem to have the patches to fix NFS+KRB5! in 2.6.18-5.el5 A package has been built which should help the problem described in this bug report. This report is therefore being closed with a resolution of CURRENTRELEASE. You may reopen this bug report if the solution does not work for you. *** Bug 230536 has been marked as a duplicate of this bug. *** |