Bug 220743

Review for release 1:
* RPM name is OK
* Source postgis-1.2.0.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of postgis-utils looks OK
* rpmlint of postgis-jdbc looks OK
* rpmlint of postgis looks OK
* File list of postgis-utils looks OK
* File list of postgis-jdbc looks OK
* File list of postgis looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)

Minor:
* Duplicate BuildRequires: jpackage-utils (by ant), ant (by ant-junit), junit (by ant-junit)

Hi,

(In reply to comment #1)
> Review for release 1:
<snip>
> Needs work:
> * BuildRoot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>   (wiki: PackagingGuidelines#BuildRoot)

Ok, fixed.

> * Spec file: some paths are not replaced with RPM macros
>   (wiki: QAChecklist item 7)

Oops, fixed. Please let me know if I'm still missing one.

> Minor:
> * Duplicate BuildRequires: jpackage-utils (by ant), ant (by ant-junit), junit
(by ant-junit)

Very good catch. This is fixed, too.

Spec URL: http://developer.postgresql.org/~devrim/rpms/other/postgis/postgis.spec
SRPM URL:
http://developer.postgresql.org/~devrim/rpms/other/postgis/postgis-1.2.0-2.src.rpm


Thanks for the review.

Regards, Devrim

Must items:

OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL,LGPL for the jdbc driver)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
59b5f89d0a0230b00d80e779bb517520  postgis-1.2.0.tar.gz
59b5f89d0a0230b00d80e779bb517520  postgis-1.2.0.tar.gz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files are good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have sane scriptlets.
NOT OK - Should have subpackages require base package with fully versioned
depend. You need Requires: %{name} = %{version}-%{release}
OK - Should have dist tag
OK - Should package latest version

I'll accept the package trusting you'll fix that last item.

Package Change Request
======================
Package Name: postgis
Owner: devrim 

Details:

Fedora Extras|postgis|Geographic Information Systems Extensions to
PostgreSQL|devrim|extras-qa|

Could you please add this package to owners.list?

Thanks, Devrim

cvs done. 
Sorry this got missed, but you didn't set the fedora-cvs flag, so cvsadmins
didn't see it until now. 

AFAIR this package was approved before we added these flags to bugzilla... Also
there is CVS directory for Postgis already :) But thanks anyway.

Regards, Devrim

Yeah, could be... however, it didn't have a owners.list entry, so no bugzilla
component and all sorts of other issues. Also, it doesn't appear to have a F-7
branch. Feel free to request one if you need it. 

Package Change Request
======================
Package Name: postgis
New Branches : F-7 EL-5 

Package Change Request
======================
Package Name: postgis
New Branches: EL-4

cvs done.

*** Bug 171040 has been marked as a duplicate of this bug. ***