Bug 2207997
| Summary: | [RHEL9]python-pip: Python tarfile extraction needs change to avoid a warning (CVE-2007-4559 mitigation) | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | Petr Viktorin <pviktori> | |
| Component: | python-pip | Assignee: | Petr Viktorin <pviktori> | |
| Status: | VERIFIED --- | QA Contact: | Lukáš Zachar <lzachar> | |
| Severity: | unspecified | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 9.3 | CC: | cstratak | |
| Target Milestone: | rc | Keywords: | Triaged | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | python-pip-21.2.3-7.el9 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 2218241 2218247 2218267 (view as bug list) | Environment: | ||
| Last Closed: | Type: | Bug | ||
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 263261 | |||
| Bug Blocks: | ||||
Upstream issue: https://github.com/pypa/pip/issues/12111 (This doesn't cover bundled libraries) Verified in the PR. For verification:
Run this script to create a malformed tarball:
"""
import tarfile
def mkinfo(name, **kwargs):
tarinfo = tarfile.TarInfo(name=name)
for name, value in kwargs.items():
setattr(tarinfo, name, value)
return tarinfo
with tarfile.open('evil.tar.gz', 'w:gz') as tf:
tf.addfile(mkinfo('./pyproject.toml'))
tf.addfile(mkinfo('./tmp', type=tarfile.SYMTYPE,
linkname='../../../../../../../../tmp'))
tf.addfile(mkinfo('./tmp/poc'))
"""
And then run python3 -m pip install evil.tar.gz
On an unpatched pip the evil.tar.gz will install successfully.
On a fixed/patched one a "tarfile.OutsideDestinationError: 'tmp/poc' would be extracted to '/tmp/poc', which is outside the destination" will appear.
|
> We may need a security report for pip Probably a false alarm. I *can* make a tarball that causes this function to write a file to an arbitrary location in the filesystem... but all code paths I could find in pip that use this function then run code from the extracted tarball. So users need to trust what they `pip download`, anyway.