Bug 2208325

Summary:	QEMU: ui/cursor: make width/height unsigned 16-bit integer
Product:	[Other] Security Response	Reporter:	Mauro Matteo Cascella <mcascell>
Component:	vulnerability	Assignee:	Red Hat Product Security <security-response-team>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	carnil, ddepaula, eglynn, jen, jferlan, jjoyce, jmaloy, knoel, lhh, mburns, mgarciac, mkenneth, mrezanin, mst, pbonzini, security-response-team, spower, virt-maint
Target Milestone:	---	Keywords:	Security
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:	CVE-2023-1601 was originally allocated because of an incomplete fix for CVE-2021-4206. The CVE was subsequently rejected as the flaw was not confirmed.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-24 08:44:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2208327, 2208328, 2208330, 2208331
Bug Blocks:	2208329

Description Mauro Matteo Cascella 2023-05-18 15:28:26 UTC

The cursor_alloc() function still accepts a signed integer for both the cursor width and height. A specially crafted negative value could make datasize wrap around and cause the next allocation to be 0, potentially leading to a heap buffer overflow.

Proposed upstream patch:
https://lists.nongnu.org/archive/html/qemu-devel/2023-05/msg01907.html

Original CVE-2021-4206:
https://bugzilla.redhat.com/show_bug.cgi?id=2036998

*** EDIT ***
CVE-2023-1601 was originally allocated because of an alleged incomplete fix for CVE-2021-4206. The CVE was subsequently rejected as the flaw was not confirmed. See https://lists.nongnu.org/archive/html/qemu-devel/2023-05/msg05546.html.

Comment 1 Mauro Matteo Cascella 2023-05-18 15:28:55 UTC

Created qemu tracking bugs for this issue:

Affects: epel-all [bug 2208328]
Affects: fedora-all [bug 2208327]

Comment 3 Salvatore Bonaccorso 2023-05-23 10:19:40 UTC

Hi

Should this CVE be rejected? According to https://lists.nongnu.org/archive/html/qemu-devel/2023-05/msg05546.html there seems to be no code path which can trigger the overflow.

Regards,
Salvatore

Comment 4 Mauro Matteo Cascella 2023-05-23 15:00:44 UTC

Hi, yes I'm going to reject this CVE. Thanks.

Comment 5 Mauro Matteo Cascella 2023-05-24 09:02:54 UTC

Updated patch:
https://lists.nongnu.org/archive/html/qemu-devel/2023-05/msg05867.html

Comment 6 Mauro Matteo Cascella 2023-07-17 13:19:37 UTC

Upstream commit:
https://gitlab.com/qemu-project/qemu/-/commit/4c93ce54e7114aae33100d2ee4f2b36e451a1d06