Bug 2208339

I'm showing branches already exist for EPEL8/9

+++ This bug was initially created as a clone of Bug #2112130 +++

--- Additional comment from Thomas Juberg on 2022-12-23 20:24:28 UTC ---

Any chance we could get this updated for EPEL 8/9?

1.4.0 contains a fix for crash on EPYC processors https://github.com/prometheus/node_exporter/issues/2299 which I keep hitting.

1.4.1/1.5.0 contains security related fixes for crypto, net and exporter-toolkit

--- Additional comment from Mark E. Fuller on 2023-05-10 22:24:40 UTC ---

I will do my best to work on this

--- Additional comment from Mark E. Fuller on 2023-05-10 23:22:09 UTC ---

I've identified three new packages on which this is dependent (submitted for review)

There is then a build error for the package (https://download.copr.fedorainfracloud.org/results/fuller/go-sig_prometheus/fedora-rawhide-x86_64/05908811-golang-github-prometheus-node-exporter/builder-live.log.gz) which I don't have time to sort out yet - insight from interested parties is more than welcome

--- Additional comment from Elliott Sales de Andrade on 2023-05-10 23:41:09 UTC ---

_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:89:21: msg.Attributes.Alias undefined (type *rtnetlink.LinkAttributes has no field or method Alias)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:90:30: msg.Attributes.Alias undefined (type *rtnetlink.LinkAttributes has no field or method Alias)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:101:71: msg.Attributes.Carrier undefined (type *rtnetlink.LinkAttributes has no field or method Carrier)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:102:99: msg.Attributes.CarrierChanges undefined (type *rtnetlink.LinkAttributes has no field or method CarrierChanges)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:103:105: msg.Attributes.CarrierUpCount undefined (type *rtnetlink.LinkAttributes has no field or method CarrierUpCount)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:104:109: msg.Attributes.CarrierDownCount undefined (type *rtnetlink.LinkAttributes has no field or method CarrierDownCount)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:107:87: msg.Attributes.LinkMode undefined (type *rtnetlink.LinkAttributes has no field or method LinkMode)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:108:71: msg.Attributes.LinkMode undefined (type *rtnetlink.LinkAttributes has no field or method LinkMode)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:120:83: msg.Attributes.NetDevGroup undefined (type *rtnetlink.LinkAttributes has no field or method NetDevGroup)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:121:99: msg.Attributes.TxQueueLen undefined (type *rtnetlink.LinkAttributes has no field or method TxQueueLen)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:121:99: too many errors

I didn't look into which netlink package node-exporter uses, but perhaps bug 2142810?

--- Additional comment from Mark E. Fuller on 2023-05-11 14:38:25 UTC ---

Thanks for that - I identified and updated three libraries in rawhide to make some progress, including closing that bug.

I've opened a PR that needs review (and likely revision) to also get prometheus-procfs up-to-date: https://src.fedoraproject.org/rpms/golang-github-prometheus-procfs/pull-request/2

There are a further three new packages that require review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2198968
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2198971
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2198973

The most recent build errors now appear to be with prometheus-procfs, which is confusing since it's updated in the COPR: https://copr.fedorainfracloud.org/coprs/fuller/go-sig_prometheus/build/5911523/

--- Additional comment from Mark E. Fuller on 2023-05-17 21:07:46 UTC ---

Finally got the COPR build - should be in rawhide soon

Thanks for all the help

--- Additional comment from Fedora Update System on 2023-05-18 14:23:51 UTC ---

FEDORA-2023-dfdd9630df has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-dfdd9630df

--- Additional comment from Fedora Update System on 2023-05-18 14:25:26 UTC ---

FEDORA-2023-dfdd9630df has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

--- Additional comment from Pat Riehecky on 2023-05-18 14:30:05 UTC ---

Can this be branched into the various EPELs?

--- Additional comment from Mark E. Fuller on 2023-05-18 14:59:30 UTC ---

Probably EPEL9, maybe also EPEL8 - can you open a "branch and build" EPEL package request? https://docs.fedoraproject.org/en-US/epel/epel-package-request/

Feel free to assign me to it or ping me via email

I'll try to get it done next week