Bug 2208964
| Summary: | Review Request: python-flit-core - PEP 517 build backend for packages using Flit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> | ||||
| Component: | Package Review | Assignee: | Maxwell G <maxwell> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | maxwell, package-review | ||||
| Target Milestone: | --- | Flags: | maxwell:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://flit.pypa.io/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | python-flit-core-3.8.0-3.fc39 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-06-02 21:01:36 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Miro Hrončok
2023-05-22 08:19:38 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5941031 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2208964-python-flit-core/fedora-rawhide-x86_64/05941031-python-flit-core/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-flit-core See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names Note that this is for unretirement. Technically, this now exists as EPEL-only package and I want to introduce it in Fedora. > python3-flit-core.noarch: W: no-documentation See the comment in the spec. I suppose I'll continue the review in https://src.fedoraproject.org/rpms/python-flit/pull-request/28. Spec URL: https://src.fedoraproject.org/fork/churchyard/rpms/python-flit/raw/cebafd9140ad47aa0b8f58a2fe64b25523be134c/f/python-flit-core.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4736/101454736/python-flit-core-3.8.0-3.fc39.src.rpm - Adjust the License tag to include flit_core/versionno.py's regex (BSD-2-Clause) Created attachment 1966265 [details]
The .spec file difference from Copr build 5941031 to 5942806
Copr build: https://copr.fedorainfracloud.org/coprs/build/5942806 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2208964-python-flit-core/fedora-rawhide-x86_64/05942806-python-flit-core/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. - [x] The License tag reflects the package contents and uses the correct identifiers. Specfile adjusted to account for flit_core/versionno.py - [x] The license text is included and marked with %license. - [x] The package builds successfully in mock. - [x] The package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. > python3-flit-core.noarch: W: no-documentation is justified with a specfile comment. - [x] The package runs tests in %check. - [x] The latest version is packaged or packaging an earlier version is justified. See https://src.fedoraproject.org/rpms/python-flit/pull-request/28#comment-143079. - [x] The packager considers avoiding confusing `%foo_name` macros. (Not a blocker) - [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name - [-] Applications: A `python3-` prefix is not used - [x] The pyproject macros are used. - [x] There are no bundled libraries. - [x] The package complies with the Python and general Packaging Guidelines. Package approved! Thanks for working on this! Tell releng that they can keep me as the main admin when you file the unretirement ticket. I added churchyard and @python-packagers-sig as admins. |