Bug 220906
Summary: | kdump init script fails when the crash kernel's commandline string is too long without a good error message | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | Amul Shah <amul.shah> |
Component: | kexec-tools | Assignee: | Neil Horman <nhorman> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Red Hat Kernel QE team <kernel-qe> |
Severity: | low | Docs Contact: | |
Priority: | medium | ||
Version: | 5.0 | CC: | jarod, mohan, qcai, vgoyal |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 5.0.0 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-02-13 17:05:53 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Attachments: |
Description
Amul Shah
2006-12-28 18:16:25 UTC
Created attachment 144491 [details]
This would be an example update to the sysconfig kdump config file
Created attachment 144492 [details]
update the init script for kdump to handle the added configuration variable
I tested passing such a long parameter list to kdump, but kdump throws an error saying "Command line overflow" and exits. The kexec-tools level is kexec-tools-1.101-112.el5. So can this bug be closed? yep This bug still exists with kexec-tools-1.101-163.el5, so no, you may not close it. Please re-read the bug. To make our lives simpler and to keep us on the same page, I am attaching my /etc/sysconfig/kdump file for you to use. You may only test this feature with /etc/init.d/kdump. You need to look at /var/log/messages to see the error messages for the kdump script failure, not the command line. DO NOT execute /sbin/kexec by hand. The kexec tools work flawlessly. [continued] The kexec tools work flawlessly. This problem pokes a hole in an otherwise excellent integration of the kdump feature. In the series of commands below, no where do I see a report for why the kdump kernel failed to load. The customer needs to see why the failure occured. [root@localhost ~]# grep APPEND /etc/sysconfig/kdump KDUMP_COMMANDLINE_APPEND="irqpoll maxcpus=1 lpj=3001000i console=tty0 console=ttyS0,115200n8 earlyprintk=serial,ttyS0,115200n8,keep debug acpi=debug" [root@localhost ~]# /etc/init.d/kdump start Starting kdump: [FAILED] [root@localhost ~]# tail -n 2 /var/log/messages Jan 23 14:24:14 localhost kdump: kexec: failed to load kdump kernel Jan 23 14:24:14 localhost kdump: failed to start up Created attachment 146330 [details]
/etc/sysconfig/kdump
Please use this file for your /etc/sysconfig/kdump. The parameters are
arbitrary and there just to make sure that your system's command line will
overflow. The ES7000's long exactmap helps me see this problem easier.
Okay, When I run 'init 3' to load kdump kernel using the init scripts with a very long parameter list, I get Starting portmap: [ OK ] Starting kdump: Command line overflow Starting kdump:[FAILED] [FAILED] Then I tried kexec-tools-1.101-163 on a POWER machine with long parameter list. kdump init script does not say the reason for kdump load failure and I need to check the /var/log/message. So the problem still exists in 163 level of kexec-tools. Mohan, mind sharing your /etc/init.d/kdump or at least doing a diff of it to see what went wrong between now and then? If the scripts are the same, then maybe /sbin/kexec was printing the error message on STDOUT and not STDERR. In the original bug report, I noted that the script gets rid of any /sbin/kexec error messages by redirect STDERR to /dev/null ("2> /dev/null"). Ok, it does appear the addition of the /dev/null redirection on kexec regressed this. I don'tthink we need a whole separate log facility to catch this though. The following patch should work just fine. Please test and confirm Created attachment 146345 [details]
patch to log output of kexec on error
Neil, you're right we don't need the added logging complexity. Thanks for the simpler fix. The change works, I can see the error in /var/log/messages. I assume this change will make it into 5.1 correct? Retargeting for 5.1. Also throwing back into Assigned, as this patch hasn't been incorporated into a package build. fixed in -164.el5. Thanks! kexec-tools-1.101-164.el5 included in 20070208.0 trees. |