Bug 2209328

Summary: Fix potential crash in logind
Product: Red Hat Enterprise Linux 8 Reporter: Ray Strode [halfline] <rstrode>
Component: systemdAssignee: David Tardon <dtardon>
Status: VERIFIED --- QA Contact: Frantisek Sumsal <fsumsal>
Severity: high Docs Contact:
Priority: high    
Version: 8.2CC: alanm, amike, brclark, casantos, dtardon, fmuellner, fsumsal, hdegoede, jamacku, joe, jwright, mboisver, mkolbas, rstrode, systemd-maint-list, tpopela
Target Milestone: rcKeywords: Bugfix, Triaged
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: systemd-239-77.el8 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: 2105959 Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2105959, 2170959    

Description Ray Strode [halfline] 2023-05-23 13:43:35 UTC 
+++ This bug was initially created as a clone of Bug #2105959 +++

--- Additional comment from Ray Strode [halfline] on 2023-02-17 13:55:35 EST ---

This is an untested starting point, that will probably need more work before it can go upstream.

It's also definitely insufficient for downstream, since it uses MetaContext, which I don't think existed in RHEL 8.

I'm just posting this here for my own notes when I revisit for 8.9

--- Additional comment from Ray Strode [halfline] on 2023-05-22 09:37:16 EDT ---

(hoping to get to this today)

--- Additional comment from Ray Strode [halfline] on 2023-05-23 09:41:54 EDT ---

So I ran into an issue with this. logind is crashing. It needs this fix:

https://github.com/systemd/systemd/commit/e5c09aad375551b9db499703ab7eb123d408ba16

(because session_set_display calls streq on a null string otherwise)
Comment 1 Ray Strode [halfline] 2023-05-24 15:10:42 UTC 
fwiw, we've decided not to use this feature.  It would still be good to fix the crasher, of course, but the feature is not needed anymore.
Comment 2 Plumber Bot 2023-07-13 11:26:29 UTC 
fix merged to github main branch -> https://github.com/redhat-plumbers/systemd-rhel8/pull/395