Bug 2209416

Summary:	Prepare for DNF 5, don't depend on `dnf`
Product:	[Fedora] Fedora	Reporter:	Evan Goode <egoode>
Component:	fedora-review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	admiller, leamas.alec, michel, ngompa13, pingou
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	fedora-review-0.10.0-2.fc38 fedora-review-0.10.0-2.fc37	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-28 02:41:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2166026

Description Evan Goode 2023-05-23 20:00:08 UTC

(I'm filing issues with all the packages that currently depend on `dnf`.)

DNF 5 is a new package manager that will replace DNF 4 in Fedora 39+:  Starting in Fedora 39, the `dnf` command will be provided by the `dnf5` package rather than the `dnf` package, and `dnf5` will obsolete `dnf`. Since fedora-review currently depends on DNF 4, it should choose one of the following strategies to avoid breaking the Fedora upgrade:

- Add support for DNF 5, and depend on the `dnf5` package in Fedora 39+ instead of `dnf`. Builds of DNF 5 are available in this COPR repository: https://copr.fedorainfracloud.org/coprs/rpmsoftwaremanagement/dnf5-unstable, and documentation is available here: https://dnf5.readthedocs.io/en/latest/.
- Alternatively, or in the meantime, change the fedora-review package to depend on `python3-dnf` instead of `dnf`, and call the `dnf-3` binary instead of `dnf`. The old DNF 4 command will still be available in the distribution, but only as `dnf-3` (the binary is called `dnf-3`  rather than `dnf4` for historical reasons; it is the "Python 3 version" of DNF). The first option is preferred to this one; it is not recommended to modify installed software using both DNF 4 and DNF 5 on the same system.
- Or, if this package is no longer being maintained, consider removing it from Fedora.

At some point, this project should adopt DNF 5, but the immediate issue is removing the dependency on `dnf`. We are planning to replace DNF with DNF5 in Fedora Rawhide very soon, by 2023-06-01, and the fedora-review package will break as long as it still depends on the `dnf` package.

For more information about the switch to DNF 5, see https://fedoraproject.org/wiki/Changes/ReplaceDnfWithDnf5.


Reproducible: Always

Comment 1 Fedora Update System 2023-07-25 02:38:13 UTC

FEDORA-2023-6e77bcd1e7 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6e77bcd1e7

Comment 2 Fedora Update System 2023-07-25 02:38:29 UTC

FEDORA-2023-a62b830c9a has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a62b830c9a

Comment 3 Fedora Update System 2023-07-26 01:57:19 UTC

FEDORA-2023-a62b830c9a has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a62b830c9a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a62b830c9a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2023-07-26 02:09:16 UTC

FEDORA-2023-6e77bcd1e7 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-6e77bcd1e7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6e77bcd1e7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2023-07-27 01:56:33 UTC

FEDORA-2023-a62b830c9a has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a62b830c9a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a62b830c9a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2023-07-27 02:55:28 UTC

FEDORA-2023-6e77bcd1e7 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-6e77bcd1e7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6e77bcd1e7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-07-28 02:41:33 UTC

FEDORA-2023-6e77bcd1e7 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2023-08-04 01:28:25 UTC

FEDORA-2023-a62b830c9a has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Evan Goode 2024-02-08 22:29:53 UTC

It seems this issue is still there, fedora-review depends on the `dnf` package in all Fedora versions: https://src.fedoraproject.org/rpms/fedora-review/blob/rawhide/f/fedora-review.spec.