Bug 2209707

Summary:	backport vsock patches for RHEL-9.3
Product:	Red Hat Enterprise Linux 9	Reporter:	Stefano Garzarella <sgarzare>
Component:	kernel	Assignee:	Stefano Garzarella <sgarzare>
kernel sub component:	KVM	QA Contact:	Qinghua Cheng <qcheng>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	unspecified
Priority:	unspecified	CC:	coli, jinzhao, juzhang, nilal, qcheng, vgoyal, virt-maint
Version:	9.3	Keywords:	Triaged
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	kernel-5.14.0-327.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	2209710 (view as bug list)		Environment:
Last Closed:	2023-11-07 08:45:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Deadline:	2023-06-19

Description Stefano Garzarella 2023-05-24 15:05:43 UTC

This is a preliminary list of vsock patches we have in Linux 6.4-rc4 that we should backport into RHEL-9.3:

6d4486efe9c6 vsock: avoid to close connected socket after the timeout
eaaa4e923979 vsock/loopback: don't disable irqs for queue access
b5d54eb5899a vsock/test: update expected return values
02ab696febab vsock: return errors other than -ENOMEM to socket
f59f3006ca7b vsock/vmci: convert VMCI error code to -ENOMEM on receive
ffa5395a7901 vsock/vmci: convert VMCI error code to -ENOMEM on send
f9d2b1e146e0 virtio/vsock: fix leaks due to missing skb owner
25209a3209ec test/vsock: new skbuff appending test
b8d2f61fdf2a virtio/vsock: WARN_ONCE() for invalid state of socket
f7154d967bc4 virtio/vsock: fix header length on skb merging
d61bd8c1fd02 selftests/bpf: add a test case for vsock sockmap
c7c605c982d6 selftests/bpf: add vsock to vmtest.sh
634f1a7110b4 vsock: support sockmap
24265c2c91ad testing/vsock: add vsock_perf to gitignore
e3ec366eb0d1 virtio/vsock: check argument to avoid no effect call
b68ffb1b3bee virtio/vsock: allocate multiple skbuffs on tx
b465518dc27d vsock/loopback: use only sk_buff_head.lock to protect the packet queue
4d1f51551777 virtio/vsock: check transport before skb allocation
7e699d2a4e81 test/vsock: copy to user failure test
8daaf39f7f6e virtio/vsock: don't drop skbuff on copy failure
6825e6b4f8e5 virtio/vsock: remove redundant 'skb_pull()' call
077706165717 virtio/vsock: don't use skbuff state to account credit
759aba1e6e7d vhost: remove unused paramete
71dc9ec9ac7d virtio/vsock: replace virtio_vsock_pkt with sk_buff
8abbffd27ced test/vsock: vsock_perf utility
685a21c314a8 test/vsock: add big message test
5c338112e48a test/vsock: rework message bounds test
c43170b7e157 vsock: return errors other than -ENOMEM to socket

New features:
- replaced virtio_vsock_pkt with sk_buff to allow new features and improve performance (usual test can be used)
- supported sockmap (new tests included)
- returned better error on send()/recv() failure (tests updated)

Comment 1 Stefano Garzarella 2023-05-25 15:10:06 UTC

I'll remove sockmap support from the backport since there are several conflicts and it is still not well tested upstream.

Comment 5 Qinghua Cheng 2023-06-13 05:42:36 UTC

Pre-verify on rhel 9.3

Host: rhel 9.3
kernel: 5.14.0-318.2602_879152635.el9.x86_64
qemu-kvm: qemu-kvm-8.0.0-1.el9.x86_64

Guest: rhel 9.3 
kernel: 5.14.0-318.2602_879152635.el9.x86_64

vsock automation test PASS.

Comment 9 Qinghua Cheng 2023-06-19 03:05:18 UTC

Verified on rhel 9.3

Host rhel 9.3
kernel: 5.14.0-327.el9.x86_64
qemu-kvm: qemu-kvm-8.0.0-5.el9.x86_64

guest: rhel 9.3 
kernel: 5.14.0-327.el9.x86_64

ALL tests PASS. No new issue found.

Comment 11 errata-xmlrpc 2023-11-07 08:45:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: kernel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6583