Bug 2209769

Summary: mount.cifs failes with vers=1.0 after latest update
Product: [Fedora] Fedora Reporter: The PowerTool <ThePowerTool_SC>
Component: cifs-utilsAssignee: Alexander Bokovoy <abokovoy>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 36CC: abokovoy, jlayton, luk.claes, pfilipen, sprabhu, ssorce
Target Milestone: ---Keywords: Desktop, Regression
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-25 05:57:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description The PowerTool 2023-05-24 17:35:45 UTC
after dnf update mount.cifs fails when using vers=1.0 connecting to old NAS.

Reproducible: Always

Steps to Reproduce:
1.Fedora 36 with latest update
2.mount.cifs or automount old CIFS share using vers=1.0
3.mount fails with "mount error(5): Input/output error"
Actual Results:  
mount fails as follows:

[guest@client ~]$ mount ./[share]
mount error(5): Input/output error
Refer to the mount.cifs(8) manual page (e.g. man mount.cifs) and kernel log messages (dmesg)

dmesg:
[ 1273.381033] Use of the less secure dialect vers=1.0 is not recommended unless required for access to very old servers

[ 1273.381039] CIFS: VFS: Use of the less secure dialect vers=1.0 is not recommended unless required for access to very old servers
[ 1273.381050] CIFS: Attempting to mount \\freenas\[share]
[ 1273.408368] CIFS: VFS: cifs_mount failed w/return code = -5

Expected Results:  
mount successfully completes

/etc/fstab:

//freenas/RAID3 /home/[user]/freenas cifs vers=1.0,rw,auto,user,noperm,uid=1000,gid=1000,credentials=/home/[user]/.cifscredentials 0 0

Comment 1 Alexander Bokovoy 2023-05-24 17:49:32 UTC
Fedora 36 is not supported anymore. Please try against a newer Fedora version, as we will not be able to fix anything in Fedora 36 anymore.

What did you use before upgrade? cifs-utils were built to Fedora 36 a year ago and did not change since that time.

Additionally, Samba 4.16.0 did deprecate and disable NT1 protocol flavor by default which means it is not available by default unless you have explicitly enabled it in /etc/samba/smb.conf for the client case.
See https://www.samba.org/samba/history/samba-4.16.0.html for more details.

Comment 2 The PowerTool 2023-05-24 19:03:51 UTC
Understood that Fedora 36 is no longer supported.

Answering your question: I used the fstab, as stated, above.  The share was auto mounted on boot.  After the latest dnf update that stopped working and I am no longer able to mount the shares.

I was very excited about your comment but then confused by the link.  The link states "deprecated and
disabled by default, but not removed" but then later states it's removed and you must "use an older version of Samba"

I attempted to rollback the latest update.  It says it completed the rollback but the issue still persists:
    54 | update                                                                                                                                                                                  | 2023-05-20 14:19 | C, E, I, O, U  |  515 E<
[root@f36client ~]# dnf history rollback 54
Last metadata expiration check: 1:41:34 ago on Wed 24 May 2023 13:05:25 EDT.
Dependencies resolved.
Nothing to do.
Complete!
[root@f36client ~]# 

It appears upgrading to Fedora 37 will not resolve this issue.  Is there a work-around?  Thank you for your time and attention!

Comment 3 The PowerTool 2023-05-24 20:36:48 UTC
Upon further research, it appears support was dropped from the kernel with the latest kernel update.

Comment 4 The PowerTool 2023-05-24 22:28:12 UTC
Why would an unsupported Fedora 36 receive an update to break samba and cause a need for support?

https://bugzilla.kernel.org/show_bug.cgi?id=215375 shows this was documented back in 2021 and a well-hidden update clearly stated as a problem which the dev responsible subsequently released a patch to undo.

Given this was identified as an issue in 2021 shouldn't there be provisions for fixing this problem introduced in a recent patch to Fedora 36?

Comment 5 Alexander Bokovoy 2023-05-25 05:57:21 UTC
As I said, there is no way to do anything in Fedora 36 *now* that Fedora 38 is out. All F36 updates were received at the time when it was a supported release.

At this point, nothing can be done in Fedora 36 to unroll the builds or to change any existing builds, or to introduce new ones.

Support for SMB1 was removed upstream in Linux kernel. This means all Linux distributions building a kernel with that change are affected, not just Fedora.

Fedora kernel policy says this: (https://fedoraproject.org/wiki/Kernel)

-------------
The current policy of the Fedora kernel is to stay on the latest released kernel and rebase when it goes EOL. This means that each released Fedora version (e.g. F33, F34) will receive multiple major kernel versions throughout its life cycle.
-------------

I am closing this bug as WONTFIX.