Bug 2209772
| Summary: | Review Request: golang-github-bep-helpers - A utils package with a less burdened name | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Maverick Kaung <mavjs01> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mavjs01, package-review |
| Target Milestone: | --- | Flags: | mavjs01:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-06-02 20:01:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2209669 | ||
|
Description
W. Michael Petullo
2023-05-24 18:02:39 UTC
Golang Package Review
==============
Note: Most of the heavy lifting is done by go2rpm
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The SPEC file looks sane.
- [x] Latest version is packaged.
- [x] License field in the package spec file matches the actual license, and it uses correct identifiers.
- [x] The package builds successfully in mock. (done via fedora-review)
- [x] Package successfully compiles and builds into binary rpms on at least one supported primary architecture. (done via fedora-review)
- [x] Package installs properly. (done via fedora-review)
- [x] Rpmlint is run on all rpms the build produces. (done via fedora-review)
- [x] The package runs tests in %check. (done via fedora-review)
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default, this is however a library)
- [x] The package complies with the Golang and general Packaging Guidelines.
- [x] hugo is built for golang exclusive arch, therefore `%gometa -f` is justified here as well.
Package approved!
Looking at the packages you maintain, I believe you already know the drill, however, just a small reminder to do the following on import:
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
Thank you for your continued contributions!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bep-helpers FEDORA-2023-c838c6afe0 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c838c6afe0 FEDORA-2023-c838c6afe0 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |