Bug 2210485
| Summary: | Review Request: golang-github-minio-highwayhash - Native Go version of HighwayHash | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mark E. Fuller <mark.e.fuller> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-06-11 19:49:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1939310 | ||
|
Description
Mark E. Fuller
2023-05-27 20:10:06 UTC
Two issues with this spec: golang-github-minio-highwayhash-devel.noarch: E: summary-too-long Native Go version of HighwayHash with optimized assembly implementations on Intel and ARM. Able to process over 10 GB/sec on a single core on Intel CPUs - https://en.wikipedia.org/wiki/HighwayHash Also, not sure if including URLs in description is a good idea. And more important: > BuildError: The following noarch package built differently on different architectures: golang-github-minio-highwayhash-devel-1.0.2-1.fc39.noarch.rpm > rpmdiff output was: > removed REQUIRES golang(golang.org/x/sys/cpu) You can check at https://koji.fedoraproject.org/koji/taskinfo?taskID=101901699 Look at golang-github-aead-chacha20.spec or golang-x-crypto.spec to see how this can be fixed. Updated to fix both issues - thanks for catching these: Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora-rawhide-x86_64/05969885-golang-github-minio-highwayhash/golang-github-minio-highwayhash.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora-rawhide-x86_64/05969885-golang-github-minio-highwayhash/golang-github-minio-highwayhash-1.0.2-1.fc39.src.rpm Both, the spec file and the spec file in srpm are the same as the old ones. What am I doing... Sorry about that and thanks for your patience Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora-rawhide-x86_64/06020555-golang-github-minio-highwayhash/golang-github-minio-highwayhash.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora-rawhide-x86_64/06020555-golang-github-minio-highwayhash/golang-github-minio-highwayhash-1.0.2-1.fc39.src.rpm > golang-github-minio-highwayhash-devel.noarch: E: summary-too-long Native Go version of HighwayHash with optimized assembly implementations on Intel and ARM.
> golang-github-minio-highwayhash-devel.noarch: W: summary-ended-with-dot Native Go version of HighwayHash with optimized assembly implementations on Intel and ARM.
Fix those and I'll approve the package.
Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora-rawhide-x86_64/06061684-golang-github-minio-highwayhash/golang-github-minio-highwayhash.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora-rawhide-x86_64/06061684-golang-github-minio-highwayhash/golang-github-minio-highwayhash-1.0.2-1.fc39.src.rpm Did you remove the fix for "golang(golang.org/x/sys/cpu)"? There was an issue with my files syncing and I lost some work - sorry about missing that Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora-rawhide-x86_64/06061757-golang-github-minio-highwayhash/golang-github-minio-highwayhash.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora-rawhide-x86_64/06061757-golang-github-minio-highwayhash/golang-github-minio-highwayhash-1.0.2-1.fc39.src.rpm I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-minio-highwayhash FEDORA-2023-0ec75909f7 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0ec75909f7 FEDORA-2023-0ec75909f7 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |