Bug 221054

Added FE-NEEDSPONSOR

* In build log:

gerbv.c:1526: warning: call to __builtin___snprintf_chk will
always overflow destination buffer


* Gerber file format support fails to load test files.

* Drill file format support crashes with buffer overflow.

* Passing files at the command-line results in 100% buffer
overflow crash:

*** buffer overflow detected ***: gerbv terminated
======= Backtrace: =========
/lib/libc.so.6(__chk_fail+0x41)[0x87c161]
/lib/libc.so.6[0x87bba3]
/lib/libc.so.6(__snprintf_chk+0x37)[0x87ba87]
gerbv[0x8055686]
gerbv[0x805625a]
/lib/libglib-2.0.so.0[0x12a5e1]


* Directories %{_datadir}/gerbv and %{_datadir}/gerbv/scheme
are not included:

$ rpmls -p /home/qa/tmp/rpm/RPMS/gerbv-1.0.2-1.i386.rpm
-rwxr-xr-x  /usr/bin/gerbv
-rw-r--r--  /usr/share/applications/fedora-gerbv.desktop
-rw-r--r--  /usr/share/gerbv/scheme/init.scm
-rw-r--r--  /usr/share/icons/hicolor/48x48/apps/gerbv.png
-rw-r--r--  /usr/share/man/man1/gerbv.1.gz


* Scriptlets for GTK icon cache are missing:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda


* No %doc files are included. Not even the GPL license.

* Manual pages are marked %doc automatically.

* Upstream project site contains the following warning: "If anyone is interested
to takeover this project, please contact Stefan. Else this project will risk to
rot away yet again."


Hints:

* It is commonly considered better style to make "Summary" in
headline-style:

Summary: Gerber file viewer from the gEDA toolkit

* Second sentence in %description is missing punctuation.

* Manual pages contains unexpanded ${prefix}.

Created attachment 144637 [details]
Chitlesh's gerbv patch

Created attachment 144638 [details]
Chitlesh's gerbv spec file

Hello,
I've recently attached a patch and my gerbv file which I was working on some
months ago.

My spec file will help you fix the issues pointed by Michael's review.

However, I missed out some materials on the "doc" directory, probably you can
add them to the spec file. :)

By the way, I'm the geda suite packager for fedora:)

Chitlesh said:
> By the way, I'm the geda suite packager for fedora:)

Sorry, didn't mean to step on anyone's feet!

Michael:

Thanks for the feedback, I'll try and resubmit within the next few days.

When I originally submitted, I didn't realise that there was this maintainership
problem (err... I think I must have been blind or something).  Perhaps this
package shouldn't go into extras because of lack of upstream maintenance.  I've
posted about this on the gEDA-devel mailing list to see whether anyone's
thinking about maintaining it.

(In reply to comment #6)
> Chitlesh said:
> > By the way, I'm the geda suite packager for fedora:)
> 
> Sorry, didn't mean to step on anyone's feet!

It's not the case:)
I'm glad someone is pushing scientific/electronic tools inside. :) keep it up

Just a note:  I haven't died.  Laptop death and exams are getting in the way! 
I'll be back soon...

You should also fix the desktop file 

--- rpmbuild/SOURCES/gerbv-1.0.2/desktop/gerbv.desktop  2006-07-26
09:35:40.000000000 +0200
+++ /usr/share/applications/gerbv.desktop       2007-02-13 23:47:19.000000000 +0100
@@ -7,4 +7,5 @@
 Type=Application
 Exec=gerbv
 Icon=gerbv
-Categories=Education;Electronics;Engineering;
+Categories=Qt;KDE;Education;Science;Engineering;

see how it can be done in your spec file with desktop-file-utils instead of the
patch: http://fedoraproject.org/wiki/PackagingDrafts/DesktopFiles

(easy fix)

ping, Robert?

ping again?

Hello.  Apologies for the long absence.

The continuous barrage of non-gerbv related stuff that I've had to do since
filing this review request has not yet stopped.  If someone else wants to submit
a review request for it, then I'm not stopping them...

Chitlesh, are you insterested in being the maintainer
of this package (gerbv)?

If you are not, or any response cannot be gained within
one week from anyone, I will once close this bug as NOTABUG

(In reply to comment #13)
> Chitlesh, are you insterested in being the maintainer
> of this package (gerbv)?

Actually I would love to. But however, there isn't any upstream for this 
package to fix the following bugs from comment #2:

> * In build log:
> 
> gerbv.c:1526: warning: call to __builtin___snprintf_chk will
> always overflow destination buffer
> 
> 
> * Gerber file format support fails to load test files.
> 
> * Drill file format support crashes with buffer overflow.
> 
> * Passing files at the command-line results in 100% buffer
> overflow crash:
> 
> *** buffer overflow detected ***: gerbv terminated
> ======= Backtrace: =========
> /lib/libc.so.6(__chk_fail+0x41)[0x87c161]
> /lib/libc.so.6[0x87bba3]
> /lib/libc.so.6(__snprintf_chk+0x37)[0x87ba87]
> gerbv[0x8055686]
> gerbv[0x805625a]
> /lib/libglib-2.0.so.0[0x12a5e1]

Chitlesh asked me to look into the snprint issue:

This patch should fix it:

--- src/gerbv.c~        2007-05-26 06:33:50.000000000 +0200
+++ src/gerbv.c 2007-05-26 06:33:50.000000000 +0200
@@ -1523,7 +1523,7 @@
            /*
             * Show progress in status bar
             */
-           snprintf(screen.statusbar.msgstr, MAX_STATUSMSGLEN,
+           snprintf(screen.statusbar.msgstr, MAX_ERRMSGLEN,
                     "%d %s...",
                     i, screen.file[i]->basename);
            update_statusbar(&screen);

Does the patch by Ralf work for you?

Yes, Thanks Ralf, the patch works.

However now, 
file -> "open project" fails to open examples provided by this package.
But if one open a project file or a gerbv file from the konsole, gerbv opens 
it successfully. I'll dig later on.

PS: I'm in examination period for the following two weeks. I might not answer 
my mails during that interval.

(In reply to comment #17)
> However now, 
> file -> "open project" fails to open examples provided by this package.
> But if one open a project file or a gerbv file from the konsole, gerbv opens 
> it successfully. I'll dig later on.

Ok, I've found what was wrong. Actually it wasn't the code that was failing 
this time but rather the examples provided by gerbv are outdated. I'll update 
them and file another review under my name later on.

I think it is better that you close this bug and create new
review request once you create a new spec/srpm for this package
and mark this as duplicate of the new review request..

I'm thereby closing this bug as duplicate.

*** This bug has been marked as a duplicate of 245985 ***

Package Change Request
=======================
Package Name: gerbv
Short Description: Gerber file viewer from the gEDA toolkit
Owners: chitlesh
Branches: EL-5

cvs done.