Bug 2210565

Summary: Direct migration completes with warnings, failing on DVM phase
Product: Migration Toolkit for Containers Reporter: mohamed <midays>
Component: ControllerAssignee: Dylan Murray <dymurray>
Status: CLOSED ERRATA QA Contact: mohamed <midays>
Severity: high Docs Contact:
Priority: unspecified    
Version: 1.7.10CC: akarol, dymurray, rjohnson
Target Milestone: ---Keywords: Regression
Target Release: 1.7.10   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-06-15 09:48:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description mohamed 2023-05-28 15:27:56 UTC
Description of problem:
When executing a direct migration it fails on the DVM phase

Version-Release number of selected component (if applicable):
MTC 1.7.10 
OCP 3.11 -> OCP 4.12

How reproducible:
Always

Steps to Reproduce:
1. Create a DVM migration
2. Execute migration

Actual results:
Migration completes with warnings, the DVM phase fails

Expected results:
The migration should be completed without any error or warning


Additional info:

From the logs found this error:

openshift-migration migration-controller-6f77fc5755-bdnxk mtc {"level":"info","ts":1685285958.1893559,"logger":"directvolume","msg":"Phase execution failed.","dvm":"migration-25908-qwlcv","migMigration":"migration-25908","phase":"CreateRsyncTransferPods","phaseDescription":"Creating Rsync daemon pods on the target cluster","error":"template: config:16: function \"fi\" not defined"}
openshift-migration migration-controller-6f77fc5755-bdnxk mtc {"level":"info","ts":1685285958.189384,"logger":"directvolume","msg":"","dvm":"migration-25908-qwlcv","migMigration":"migration-25908","error":"template: config:16: function \"fi\" not defined","stacktrace":"\ngithub.com/konveyor/mig-controller/pkg/controller/directvolumemigration.(*Task).ensureRsyncTransferServer()\n\t/remote-source/mig-controller/app/pkg/controller/directvolumemigration/rsync.go:415\ngithub.com/konveyor/mig-controller/pkg/controller/directvolumemigration.(*Task).Run()\n\t/remote-source/mig-controller/app/pkg/controller/directvolumemigration/task.go:331\ngithub.com/konveyor/mig-controller/pkg/controller/directvolumemigration.(*ReconcileDirectVolumeMigration).migrate()\n\t/remote-source/mig-controller/app/pkg/controller/directvolumemigration/migrate.go:52\ngithub.com/konveyor/mig-controller/pkg/controller/directvolumemigration.(*ReconcileDirectVolumeMigration).Reconcile()\n\t/remote-source/mig-controller/app/pkg/controller/directvolumemigration/directvolumemigration_controller.go:148\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler()\n\t/remote-source/mig-controller/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:298\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem()\n\t/remote-source/mig-controller/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:253\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()\n\t/remote-source/mig-controller/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:214\nruntime.goexit()\n\t/usr/lib/golang/src/runtime/asm_amd64.s:1594"}

Comment 1 mohamed 2023-05-30 09:04:42 UTC
This bug is reproducible on 4.x -> 4.x migrations

Comment 2 Dylan Murray 2023-05-31 01:13:08 UTC
https://github.com/migtools/crane-lib/pull/118

Comment 6 mohamed 2023-06-01 14:09:14 UTC
Verified in the MTC latest version

Direct migration is passing

Comment 10 errata-xmlrpc 2023-06-15 09:48:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Migration Toolkit for Containers (MTC) 1.7.10 security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:3624