Bug 2210584

Summary:	Review Request: rust-gix-validate - Validation functions for various kinds of names in git
Product:	[Fedora] Fedora	Reporter:	blinxen <h-k-81>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-06-06 21:34:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description blinxen 2023-05-28 20:46:58 UTC

Spec URL: https://blinxen.fedorapeople.org/gix-validate/rust-gix-validate.spec
SRPM URL: https://blinxen.fedorapeople.org/gix-validate/rust-gix-validate-0.7.4-1.fc39.src.rpm
Description: Validation functions for various kinds of names in git
Fedora Account System Username: blinxen

Comment 1 Fabio Valentini 2023-06-06 19:02:21 UTC

Can you update to v0.7.5? It includes your license file PR.

Comment 2 blinxen 2023-06-06 19:24:38 UTC

Updated to latest version

Comment 3 blinxen 2023-06-06 19:26:09 UTC

Here are the updated URLs:

Spec URL: https://blinxen.fedorapeople.org/gix-validate/rust-gix-validate.spec
SRPM URL: https://blinxen.fedorapeople.org/gix-validate/rust-gix-validate-0.7.5-1.fc39.src.rpm

Comment 4 Fabio Valentini 2023-06-06 20:16:23 UTC

Thanks! Looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 5 Fedora Admin user for bugzilla script actions 2023-06-06 20:47:22 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-validate

Comment 6 blinxen 2023-06-06 21:34:43 UTC

Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-ee93644f8d