Bug 221084
| Summary: | Review Request: dkms - Dynamic Kernel Module Support | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matt Domsch <matt_domsch> |
| Component: | Package Review | Assignee: | Michael E Brown <mebrown> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gauret, lemenkov, opensource |
| Target Milestone: | --- | Flags: | mebrown:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-22 16:29:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Matt Domsch
2007-01-01 14:26:40 UTC
You use hardcoded directory names instead of macros, this violates the Packaging Guidelines: http://fedoraproject.org/wiki/Packaging/Guidelines#head-255d52ff18f82fa184a32946b82ed81e4fd8885a Package SRPM no longer resolves. 404. rpmlint:
$ rpmlint dkms-2.0.13-1.fc6.src.rpm
W: dkms strange-permission dkms-2.0.13.tar.gz 0666
probably ok
W: dkms strange-permission dkms.spec 0666
probably ok
W: dkms unversioned-explicit-provides dkms-minimal
should fix?
W: dkms macro-in-%changelog doc
should fix?
W: dkms macro-in-%changelog kernelver
should fix?
W: dkms no-%build-section
possibly add empty %build?
W: dkms mixed-use-of-spaces-and-tabs (spaces: line 60, tab: line 28)
should fix?
$ rpmlint ./dkms-2.0.13-1.fc6.noarch.rpm
E: dkms devel-dependency kernel-devel
probably ok.
E: dkms script-without-shebang /var/lib/dkms/dkms_dbversion
fix perms on this file? (no +x)
W: dkms dangerous-command-in-%post mv
probably ok
W: dkms dangerous-command-in-%trigger mv
probably ok
E: dkms init-script-without-chkconfig-preun /etc/init.d/dkms_autoinstaller
should fix?
W: dkms service-default-enabled /etc/init.d/dkms_autoinstaller
probably ok.
E: dkms subsys-not-used /etc/init.d/dkms_autoinstaller
not sure what this means.
W: dkms incoherent-init-script-name dkms_autoinstaller
probably ok.
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines MUST ITEMS: * rpmlint results above * meets naming guidelines * spec file name maches %{name}.spec * meets Packaging guidelines with one exception * open source license * license matches actual license * text of license included in %doc * spec in american english * spec legible * source matches upstream * package builds on all arches * no build deps * no shared libs * no Prefix: (not relocatable) * owns its dirs * do duplicate %files * includes %defattr, most %files entries properly set perms. * clean section removes buildroot * consistent use of macros * contains code * no large docs, no -doc subpackage * files in %doc are not used in runtime * no headers * no libs (static or dynamic) * is not a -devel package * no libtool archives * no GUI app, no .desktop files * doesnt own files/dirs used by other packages SHOULD ITEMS: * upstream includes license text * builds in mock * compiles on supported arches * functions as described * scriptlets sane * no -devel * no pkgconfig files * no deps outside std system dirs. http://fedoraproject.org/wiki/Packaging/NamingGuidelines * name matches upstream tarball. No illegal delimiters. * no multiple packages with same base name * spec file named correctly * versioned properly. * %{dist} tag properly used * no doc subpackage * is not an addon package http://fedoraproject.org/wiki/Packaging/Guidelines * license is GPL * no patents * no emulators * no binary firmware * no pre-built binaries. * good changelog * no 'copyright', 'packager' or 'vendor' tags * summary tag does not end in dot * no prereq * Source: tag documents where to find upstream. * good buildroot tag * no file deps * no build deps (it is a shell script) * american english * utf8 spec file * relevant docs included * no compiled code (compiler flags irrelevant) * no debuginfo since no compiled code. * no libraries (static or otherwise) * no rpath issues * config files properly (noreplace) * init script isnt marked %{config} * no .desktop files (not a GUI app) * consistent variable usage. * no %makeinstall macro usage * no locale files * scriptlets dont modify dirs they shouldnt * no conditional dependencies (--with/--without) * not relocatable * no content * owns its dirs * not a webapp Review Summary: MUST fix: * hardcoded dir names. doesnt use macros for dir names. SHOULD fix: * TIMESTAMPS: consider "install -p", "mv -p", and "cp -p" in %install and scriptlets. * no tranlated summary/descriptions (acceptable) Need to fix rpmlint errors. The dkms_dbversion is being set 0755 due to %attr() on /var/lib/dkms. Probably should make /var/lib/dkms a %dir, and separately list dkms_dbver. SUMMARY: approved with the above changes. Possibly change "Dell Computer Corporation" in spec description to "Dell, Inc." List of macros for directory names: http://fedoraproject.org/wiki/Extras/RPMMacros no longer blocks FE-NEW. |