Bug 221108 (openarena)
Summary: | Review Request: openarena - first person shooter | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michał Bentkowski <mr.ecik> |
Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | lemenkov |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-01-12 21:54:11 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Michał Bentkowski
2007-01-01 22:46:29 UTC
==== REVIEW CHECKLIST ==== - rpmlint output: W: openarena-data no-documentation permissible although I usually suggest atleast placing the license file in the sub-package. - package named according to package naming guidelines - spec filename matches %{name} - package meets packaging guidelines - licensed with open source compatible license - license field matches actual license - license file included in %doc - spec file written in American english - spec file legible although I would suggest a little extra whitespace in a couple places to make parsing the spec file easier. - sources match upstream 0c2c27456a11331d61448278a1e9aaad /home/chris/oa060.tar.gz - package successfully compiles and builds on FC6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries stored in ldconfig default path - package is not relocatable - package owns all directories it creates - directories it does not create owned by default packages - no duplicates listed in %files - file permissions set properly - package contains proper %clean section - macro usage consistent - package contains code - no large documentation files - files in %doc do not affect runtime - no header files or static libraries - no pkgconfig files - no library files with suffix - no need for devel subpackage - no .la files - package contains proper .desktop file - package does not own files or directories owned by other packages *** APPROVED *** ==== SHOULD FIX ==== - add %doc doc/COPYING to data subpackage - remove LINUXNOTES from %doc After fixing some ppc problems, I finally managed to build that. Closing. |