Bug 2211692

Summary:	Review Request: firmitas - Simple notification service for X.509-standard TLS certificate statuses
Product:	[Fedora] Fedora	Reporter:	Akashdeep Dhar <akashdeep.dhar>
Component:	Package Review	Assignee:	Onuralp Sezer <thunderbirdtr>
Status:	CLOSED ERRATA	QA Contact:	Onuralp Sezer <thunderbirdtr>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	carl, package-review, ppisar, thunderbirdtr
Target Milestone:	---	Flags:	thunderbirdtr: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	firmitas-0.1.2-1.fc37	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-06-30 13:46:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Akashdeep Dhar 2023-06-01 14:06:56 UTC

Spec URL: https://gitlab.com/t0xic0der/firmitas/-/raw/main/firmitas.spec
SRPM URL: https://gitlab.com/t0xic0der/firmitas/uploads/50a7fff133ecabb2497b76a462108c57/firmitas-0.1.1-1.el9.src.rpm
Description: Simple notification service for X.509-standard TLS certificate statuses
Fedora Account System Username: t0xic0der

Comment 1 Onuralp Sezer 2023-06-06 12:30:07 UTC

I am taking this package to review

Comment 2 Onuralp Sezer 2023-06-06 12:54:34 UTC

I changed package name into "python-firmitas" based on Fedora Python guidelines and I made PR for bunch of fixes in spec file as well. 

https://gitlab.com/t0xic0der/firmitas/-/merge_requests/6

Also please update Spec URL after PR merged. (file name also change renamed)

Comment 3 Onuralp Sezer 2023-06-06 13:55:32 UTC

I saw PR merged and rest of them also LGTM so package approved !

Comment 4 Akashdeep Dhar 2023-06-06 13:56:45 UTC

https://gitlab.com/t0xic0der/firmitas/-/merge_requests/6 is now merged.

Thanks for your attention, @thunderbirdtr

Comment 5 Carl George 🤠 2023-06-07 02:37:45 UTC

Here are a few more fixes for the review.

https://gitlab.com/t0xic0der/firmitas/-/merge_requests/7

I also noticed that this fails to build on Rawhide due to an upper bound on cryptography in the source.  I believe new packages must successfully build on Rawhide to pass review.  I sent a separate PR to raise that upper bound.

https://gitlab.com/t0xic0der/firmitas/-/merge_requests/8

Comment 6 Akashdeep Dhar 2023-06-07 03:20:37 UTC

Thanks @carl for creating those pull requests!

I have reviewed, approved and merged them.

Comment 7 Fedora Admin user for bugzilla script actions 2023-06-08 07:09:22 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/firmitas