Bug 2212148

Summary:	Branding scripts aren't loaded in time
Product:	Red Hat Satellite	Reporter:	Ron Lavi <rlavi>
Component:	Branding	Assignee:	Ron Lavi <rlavi>
Status:	VERIFIED ---	QA Contact:	Griffin Sullivan <gsulliva>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.14.0	CC:	ehelms, gsulliva, jpathan, pcreech, sshtein
Target Milestone:	6.14.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ron Lavi 2023-06-04 11:14:47 UTC

Description of problem:

With Foreman's https://github.com/theforeman/foreman/commit/3f1ca239c8cac3218cd95a59b2834fe27cbb2bce,
the JS scripts moved to the top of the body for better performance.

The theme plugin is injecting the scripts to the bottom of the head and some errors are thrown since scripts they are dependant on are now part of the body.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. Go to any page that should be branded with Satellite's styles or Branded strings.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Griffin Sullivan 2023-07-28 16:32:09 UTC

Verified in 6.14 snap 9

JS scripts are at the top of the body in the HTML and no longer in the head.

Steps to Reproduce:

1) Login to Satellite and inspect element


Results:

Scripts are at the top of the body



Note: 

I still see warnings like the following in the console: 

DevTools failed to load source map: Could not load content for https://satellite-url.com/webpack/foreman_ansible/foreman_ansible:global-009e22f7c6304f208c72.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE


Is this something we are trying to fix with the change?