Bug 2212228

Summary:	Membership review job throws global kill switch
Product:	[Community] Bugzilla	Reporter:	Jeff Fearn 🐞 <jfearn>
Component:	Extensions	Assignee:	Jeff Fearn 🐞 <jfearn>
Extensions sub component:	RuleEngine	QA Contact:
Status:	CLOSED CURRENTRELEASE	Docs Contact:
Severity:	unspecified
Priority:	unspecified
Version:	5.0
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.0.4-rh88	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-03 00:17:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeff Fearn 🐞 2023-06-04 22:08:27 UTC

Description of problem:
If there is a mismatch between the flag name on a membership review bug and the group it is for, then the global kill switch is thrown.

Version-Release number of selected component (if applicable):
5.0.4-rh86

How reproducible:
Always

Steps to Reproduce:
1. Create a group
2. Add the group to the membership workflow
3. Create an approval flag
4. Add someone to the group
5. Create a membership review for the membership
6. Change the group name
7. Trigger the "Close Old Group membership requests" BRE rule

Actual results:
The global kill switch is thrown.

Expected results:
The kill switch is limited to the BRE group the rule belongs to.

Additional info:

Comment 2 Jeff Fearn 🐞 2023-06-28 03:38:19 UTC

On QA server.

1. Create a new group in the Red Hat category
2. Configure the group to require group signoff
3. Add a user to the group
4. Change the group name
5. Wait for the clean up job to run.

The kill switch is thrown and is limited to the Workflow BRE group.

Comment 3 Jeff Fearn 🐞 2023-06-28 23:01:36 UTC

This fix has been deployed to stage Bugzilla for a short public testing phase.

https://bugzilla.stage.redhat.com

Comment 4 Jeff Fearn 🐞 2023-07-03 00:17:37 UTC

This change is now live. If there are any issues, do not reopen this bug. Instead, you should create a new bug and reference this bug.