Bug 2212325

Summary: Update the rpm.egg to 3.2.1 in the next RHEL 7 insights-client release
Product: Red Hat Enterprise Linux 7 Reporter: Jan Senkyrik <jsenkyri>
Component: insights-clientAssignee: Alba Hita <ahitacat>
Status: CLOSED ERRATA QA Contact: Nobody <nobody>
Severity: medium Docs Contact:
Priority: high    
Version: 7.9CC: ahitacat, arpandey, cmarinea, fjansen, lmiksik, redakkan, stomsa
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: insights-client-3.1.8.el7_9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-18 07:48:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jan Senkyrik 2023-06-05 10:07:52 UTC 
Description of problem:

Latest version for RHEL 7 is insights-client-3.1.7-2.el7_9, its rpm.egg is 3.0.246.

Update the rpm.egg to 3.0.302 as we did for RHEL 8/RHEL 9.
Comment 9 Archana Pandey 2023-07-03 07:09:09 UTC 
Verification on insights-client-3.1.8-1.el7_9.noarch.rpm

Beaker Test information:
                         HOSTNAME=cloud-qe-11.idmqe.lab.eng.bos.redhat.com
                            JOBID=8029301
                         RECIPEID=14173545
                    RESULT_SERVER=
                           DISTRO=RHEL-7.9-updates-20230627.0
                     ARCHITECTURE=x86_64

>> Install insights-client package from beaker repo and check core version
[root@cloud-qe-11 ~]# insights-client --version
Client: 3.1.7
Core: 3.0.246-1                  <<<<<<< older core
[root@cloud-qe-11 ~]# 

>> upgrade insights-client to insights-client-3.1.8-1.el7_9.noarch.rpm and verify that core version should be updated to 3.2.1

 [root@cloud-qe-11 ~]# yum upgrade insights-client-3.1.8-1.el7_9.noarch.rpm 
Loaded plugins: product-id, search-disabled-repos, subscription-manager

This system is not registered with an entitlement server. You can use subscription-manager to register.

Examining insights-client-3.1.8-1.el7_9.noarch.rpm: insights-client-3.1.8-1.el7_9.noarch
Marking insights-client-3.1.8-1.el7_9.noarch.rpm as an update to insights-client-3.1.7-2.el7_9.noarch
Resolving Dependencies
--> Running transaction check
---> Package insights-client.noarch 0:3.1.7-2.el7_9 will be updated
---> Package insights-client.noarch 0:3.1.8-1.el7_9 will be an update
--> Finished Dependency Resolution

Dependencies Resolved

=======================================================================================================================================
 Package                      Arch                Version                     Repository                                          Size
=======================================================================================================================================
Updating:
 insights-client              noarch              3.1.8-1.el7_9               /insights-client-3.1.8-1.el7_9.noarch              1.4 M

Transaction Summary
=======================================================================================================================================
Upgrade  1 Package

Total size: 1.4 M
Is this ok [y/d/N]: y
Downloading packages:
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Updating   : insights-client-3.1.8-1.el7_9.noarch                                                                                1/2 
  Cleanup    : insights-client-3.1.7-2.el7_9.noarch                                                                                2/2 
  Verifying  : insights-client-3.1.8-1.el7_9.noarch                                                                                1/2 
  Verifying  : insights-client-3.1.7-2.el7_9.noarch                                                                                2/2 

Updated:
  insights-client.noarch 0:3.1.8-1.el7_9                                                                                               

Complete!
[root@cloud-qe-11 ~]# 
[root@cloud-qe-11 ~]# insights-client --version
Client: 3.1.8
Core: 3.2.1-1                                                   <<<<< Core version updated to 3.2.1 in insights-client-3.1.8-1.el7_9
[root@cloud-qe-11 ~]# 

Verification : Passed
Comment 10 Archana Pandey 2023-07-05 15:38:39 UTC 
Additional Verification: verifying that issue "insights-client when killed by OOM leaves temporary files in /var/tmp" https://bugzilla.redhat.com/show_bug.cgi?id=2009773
 Beaker Test information:
                         HOSTNAME=hpe-ml350egen8-01.hpe2.lab.eng.bos.redhat.com
                            JOBID=8035390
                         RECIPEID=14181101
                    RESULT_SERVER=
                           DISTRO=RHEL-7.9-updates-20230627.0
                     ARCHITECTURE=x86_64

>> reproducing the issue on older version of insights-client-
[root@hpe-ml350egen8-01 ~]# insights-client --version
Client: 3.1.5
Core: 3.0.227-1

[root@hpe-ml350egen8-01 ~]# ll /var/tmp/
total 0
drwx------. 3 root root 37 Jul  4 08:59 insights-client
drwxr-xr-x. 3 root root 18 Jul  4 05:12 restraintd
drwx------. 3 root root 17 Jul  4 05:12 systemd-private-b78a559943f34f84a5efa4b861c8fc06-chronyd.service-gjTEnx

> Created a large file that will be collected while upload and could cause OOM issue-

Now starting insight-client upload

[root@hpe-ml350egen8-01 ~]# systemctl start insights-client


[root@hpe-ml350egen8-01 ~]# ll /var/tmp/
total 0
drwx------. 2 root root  6 Jul  4 12:31 3_n8qf
drwx------. 3 root root 37 Jul  4 08:59 insights-client
drwxr-xr-x. 3 root root 18 Jul  4 05:12 restraintd
drwx------. 2 root root 90 Jul  4 12:26 rO5qkP
drwx------. 3 root root 17 Jul  4 05:12 systemd-private-b78a559943f34f84a5efa4b861c8fc06-chronyd.service-gjTEnx

observation : Clearly there are leftover directories in /var/tmp

=============================================================================================================================================================

>> Verifying the fix after upgrading insights-client:
[root@hpe-ml350egen8-01 ~]# insights-client --version
Client: 3.1.8
Core: 3.2.1-1

> Created a large file that will be collected while upload 

[root@hpe-ml350egen8-01 ~]# ll /var/tmp/
total 0
drwx------. 4 root root 68 Jul  5 09:52 insights-client
drwxr-xr-x. 3 root root 18 Jul  4 05:12 restraintd
drwx------. 3 root root 17 Jul  4 05:12 systemd-private-b78a559943f34f84a5efa4b861c8fc06-chronyd.service-gjTEnx

 
[root@hpe-ml350egen8-01 ~]# systemctl start insights-client
[root@hpe-ml350egen8-01 ~]# 

Look for stackrace due to OOM in /var/log/messages and then check insights service status

[root@hpe-ml350egen8-01 tmp]# systemctl status insights-client
● insights-client.service - Insights Client
   Loaded: loaded (/usr/lib/systemd/system/insights-client.service; static; vendor preset: disabled)
  Drop-In: /etc/systemd/system/insights-client.service.d
           └─memoryspace.conf
   Active: failed (Result: exit-code) since Wed 2023-07-05 11:12:41 EDT; 18min ago
     Docs: man:insights-client(8)
  Process: 52955 ExecStartPost=/bin/bash -c echo 1G >/dev/null 2>&1 > /sys/fs/cgroup/memory/system.slice/insights-client.service/memory.soft_limit_in_bytes (code=exited, status=0/SUCCESS)
  Process: 52953 ExecStartPost=/bin/bash -c echo 2G >/dev/null 2>&1 > /sys/fs/cgroup/memory/system.slice/insights-client.service/memory.memsw.limit_in_bytes (code=exited, status=0/SUCCESS)
  Process: 52952 ExecStart=/usr/bin/insights-client --retry 3 (code=exited, status=1/FAILURE)
 Main PID: 52952 (code=exited, status=1/FAILURE)

Jul 05 10:52:04 hpe-ml350egen8-01.hpe2.lab.eng.bos.redhat.com systemd[1]: Starting Insights Client...
Jul 05 10:52:04 hpe-ml350egen8-01.hpe2.lab.eng.bos.redhat.com systemd[1]: Started Insights Client.
Jul 05 10:52:12 hpe-ml350egen8-01.hpe2.lab.eng.bos.redhat.com insights-client[52952]: Starting to collect Insights data for hpe-ml350egen8-01.hpe2.lab.eng.bos.redhat.com
Jul 05 11:11:18 hpe-ml350egen8-01.hpe2.lab.eng.bos.redhat.com insights-client[52952]: Uploading Insights data.
Jul 05 11:12:41 hpe-ml350egen8-01.hpe2.lab.eng.bos.redhat.com systemd[1]: insights-client.service: main process exited, code=exited, status=1/FAILURE
Jul 05 11:12:41 hpe-ml350egen8-01.hpe2.lab.eng.bos.redhat.com systemd[1]: Unit insights-client.service entered failed state.
Jul 05 11:12:41 hpe-ml350egen8-01.hpe2.lab.eng.bos.redhat.com systemd[1]: insights-client.service failed.
[root@hpe-ml350egen8-01 tmp]# ll /var/tmp/
total 0
drwx------. 4 root root 68 Jul  5 10:52 insights-client
drwxr-xr-x. 3 root root 18 Jul  4 05:12 restraintd
drwx------. 3 root root 17 Jul  4 05:12 systemd-private-b78a559943f34f84a5efa4b861c8fc06-chronyd.service-gjTEnx
[root@hpe-ml350egen8-01 tmp]#


^^^....................No additional leftover files in 


Verification : Passed
Comment 14 errata-xmlrpc 2023-07-18 07:48:36 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (insights-client bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:4123