Bug 2212583

Summary: When linking luv.so due to missing soname in library ld fails to find luv.so
Product: [Fedora] Fedora Reporter: Chris Stone <chrisjstone79>
Component: lua-luvAssignee: Andreas Schneider <asn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 38CC: asn, chrisjstone79, michel
Target Milestone: ---Keywords: RFE
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://github.com/neovim/neovim/issues/23898#issuecomment-1577585239
Whiteboard:
Fixed In Version: lua-luv-1.44.2.1-3.fc38 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-06-11 02:02:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Chris Stone 2023-06-05 23:29:12 UTC
When attempting to build against shared luv.so ld fails to find luv.so
Example output as generated by cmake using -G ninja
LINK_LIBRARIES = -Wl,-rpath,/usr/lib64/lua/5.1: -Wl,--no-undefined -lluv
expected output shoud be path to luv.so as in this example:
LINK_LIBRARIES = -Wl,-rpath,/usr/lib64/lua/5.1:  -Wl,--no-undefined  /usr/lib64/lua/5.1/luv.so 



Reproducible: Always




luv.so needs to have a soname in order for cmake to find the correct location of the library and pass it to the link step.

Comment 1 Chris Stone 2023-06-06 08:00:38 UTC
Just tested the 1.44.2.1-3.fc39 for libluv and libluv-devel, I can confirm this resolves the issue with cmake and ld. I can also confirm this removes the need to add :STRING=-Wl,/usr/lib64/luajit/2.1/luv.so to LUV_LIBRARY when building neovim.

Comment 2 Fedora Update System 2023-06-06 08:32:58 UTC
FEDORA-2023-81366c7456 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-81366c7456

Comment 3 Fedora Update System 2023-06-07 01:38:33 UTC
FEDORA-2023-81366c7456 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-81366c7456`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-81366c7456

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2023-06-11 02:02:19 UTC
FEDORA-2023-81366c7456 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.