Bug 2212734
| Summary: | [RHEL9.3][virt-install][dasd][s390x] there will be an xfs I/O error when install guest into a used dasd with same vm name | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | bfu <bfu> |
| Component: | virt-manager | Assignee: | Thomas Huth <thuth> |
| virt-manager sub component: | Common | QA Contact: | Hongzhou Liu <hongzliu> |
| Status: | CLOSED WORKSFORME | Docs Contact: | |
| Severity: | high | ||
| Priority: | high | CC: | bfiuczyn, clegoate, cohuck, crobinso, dhorak, hannsj_uhl, hongzliu, jinzhao, juzhang, juzhou, knoel, lcong, lijin, pbonzini, pkrempa, ribarry, smitterl, stefanha, thuth, tyan, tzheng, vgoyal, virt-maint, virt-qe-z, yiwei |
| Version: | 9.3 | ||
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | s390x | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-07-20 09:16:54 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
bfu
2023-06-06 07:54:25 UTC
What you are requesting doesn't make much sense to me. It's a perfectly legitimate configuration to attempt to install a VM again into the same disk or block device so virt-manager/install, libvirt or qemu have no reason to print any error. That part of this BZ is considered "NOTABUG". Now for the XFS error, I'm not sure why the guest even prints that. The installer should not attempt to mount the block device at all until installation starts. Could you please attach the output of the virt-install command above with '--print-xml' added, to see what boot device was selected for the installation. (In reply to Peter Krempa from comment #1) > What you are requesting doesn't make much sense to me. It's a perfectly > legitimate configuration to attempt to install a VM again into the same disk > or block device so virt-manager/install, libvirt or qemu have no reason to > print any error. That part of this BZ is considered "NOTABUG". > > Now for the XFS error, I'm not sure why the guest even prints that. The > installer should not attempt to mount the block device at all until > installation starts. > > Could you please attach the output of the virt-install command above with > '--print-xml' added, to see what boot device was selected for the > installation. I'm not familiar with libvirt, but my colleague from libvirt QE told my that libvirt should report the dasd is in use, and that's what happened on x86let me involve him in this bz @lcong if virt-install a guest with same disk file and same guest name, then there would be error prompts:
# rpm -q virt-install libvirt
virt-install-4.1.0-4.el9.noarch
libvirt-9.4.0-1.el9.x86_64
# virt-install --connect qemu:///system -n vm1 --hvm --accelerate -r 2048 --vcpus=2 --os-variant rhel9.2 --disk path=/var/lib/libvirt/images/RHEL-9.3-x86_64-latest-ovmf.qcow2,bus=virtio,format=qcow2 --network network=default,model=virtio --import --noreboot --noautoconsole --serial pty --debug --memballoon model=virtio --cpu host,disable=vmx --graphics vnc --video vga --boot uefi --machine q35
...
virt-install 65543] DEBUG (cli:256) File "/usr/bin/virt-install", line 8, in <module>
virtinstall.runcli()
File "/usr/share/virt-manager/virtinst/virtinstall.py", line 1234, in runcli
sys.exit(main())
File "/usr/share/virt-manager/virtinst/virtinstall.py", line 1221, in main
guest, installer = build_guest_instance(conn, options)
File "/usr/share/virt-manager/virtinst/virtinstall.py", line 672, in build_guest_instance
cli.validate_disk(disk)
File "/usr/share/virt-manager/virtinst/cli.py", line 378, in validate_disk
check_inuse_conflict()
File "/usr/share/virt-manager/virtinst/cli.py", line 366, in check_inuse_conflict
_optional_fail(msg, "path_in_use")
File "/usr/share/virt-manager/virtinst/cli.py", line 319, in _optional_fail
fail(msg + (_(" (Use --check %s=off or "
File "/usr/share/virt-manager/virtinst/cli.py", line 256, in fail
log.debug("".join(traceback.format_stack()))
[Mon, 26 Jun 2023 21:48:56 virt-install 65543] ERROR (cli:257) Disk /var/lib/libvirt/images/RHEL-9.3-x86_64-latest-ovmf.qcow2 is already in use by other guests ['vm1']. (Use --check path_in_use=off or --check all=off to override)
(In reply to Peter Krempa from comment #1) > What you are requesting doesn't make much sense to me. It's a perfectly > legitimate configuration to attempt to install a VM again into the same disk > or block device so virt-manager/install, libvirt or qemu have no reason to > print any error. That part of this BZ is considered "NOTABUG". > > Now for the XFS error, I'm not sure why the guest even prints that. The > installer should not attempt to mount the block device at all until > installation starts. > > Could you please attach the output of the virt-install command above with > '--print-xml' added, to see what boot device was selected for the > installation. Could you please check comment #4? Moving to virt-manager for further analysis, as the check is solely implemented in virt-install. From libvirt's view it is okay to use the same image or device to back multiple VMs as long as they are not used at the same time. Thus also re-installing the same VM with another one with the same definition is not a problem. Cole when you get a chance could you please take a look and provide some comments / feedback Hi bfu! I now tried to reproduce this problem on my LPAR, but so far, I failed. When I ran virt-install a second time, I got: # virt-install --memory 4096 --name dasdtest --nographics --vcpus 4 --disk none --disk /dev/dasda --disk size=20 --cdrom /tmp/RHEL-9.3.0-20230715.d.41-s390x-dvd1.iso --os-variant rhel9-unknown ERROR Disk /dev/dasda is already in use by other guests ['dasdtest']. (Use --check path_in_use=off or --check all=off to override) I'm using: host kernel: 5.14.0-338 qemu-kvm: 8.0.0-7 libvirt: 9.3.0-2 virt-install: 4.1.0-4 A couple of questions: 1) Which version of virt-install have you been using? 2) You have two "--disk" parameters -- is the 20G disk in use here, too? 3) Which kind of software selection did you install in the guest? E.g. "Server"? Or "Minimal"? 4) Could you maybe retry with the latest versions from RHEL 9.3 ? (In reply to Thomas Huth from comment #8) > Hi bfu! I now tried to reproduce this problem on my LPAR, but so far, I > failed. When I ran virt-install a second time, I got: > > # virt-install --memory 4096 --name dasdtest --nographics --vcpus 4 --disk > none --disk /dev/dasda --disk size=20 --cdrom > /tmp/RHEL-9.3.0-20230715.d.41-s390x-dvd1.iso --os-variant rhel9-unknown > ERROR Disk /dev/dasda is already in use by other guests ['dasdtest']. > (Use --check path_in_use=off or --check all=off to override) > > I'm using: > host kernel: 5.14.0-338 > qemu-kvm: 8.0.0-7 > libvirt: 9.3.0-2 > virt-install: 4.1.0-4 > > A couple of questions: > 1) Which version of virt-install have you been using? > 2) You have two "--disk" parameters -- is the 20G disk in use here, too? > 3) Which kind of software selection did you install in the guest? E.g. > "Server"? Or "Minimal"? > 4) Could you maybe retry with the latest versions from RHEL 9.3 ? 1. virt-install-4.1.0-4.el9.noarch.rpm 2. I selected a 15.6G disk during installation 3. server with GUI(default) 4. I'm not able to reproduce it as well now... since we cannot reproduce this one, I'll close it for now, thanks for helping |