Bug 2213456

Summary:	Set maxOpenShiftVersion to block OpenShift that didn't upgrade ODF version
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Eran Tamir <etamir>
Component:	odf-operator	Assignee:	Nitin Goyal <nigoyal>
Status:	CLOSED ERRATA	QA Contact:	Vijay Avuthu <vavuthu>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.13	CC:	bkunal, ebenahar, kramdoss, muagarwa, nigoyal, ocs-bugs, odf-bz-bot
Target Milestone:	---
Target Release:	ODF 4.13.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	4.13.1-3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	2213452	Environment:
Last Closed:	2023-08-02 16:07:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2213452

Description Eran Tamir 2023-06-08 08:01:41 UTC

+++ This bug was initially created as a clone of Bug #2213452 +++

Description of problem (please be detailed as possible and provide log
snippests):

Currently, we don't block OpenShift upgrades when the ODF version is not compatible. For example, when the ODF version is 4.13 and the OpenShift version is 4.14, we should block an upgrade to 4.15 as ODF 4.13 is incompatible. 



Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?

Yes. It may cause and issue and ends with a support call. 

Is there any workaround available to the best of your knowledge?

Sometimes manual changes in the CSV can help, but it involves support and may help just to upgrade to the relevant ODF version, while part of the service may be impacted. 

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?

1

Can this issue reproducible?
Yes

Can this issue reproduce from the UI?

Yes

Comment 5 Nitin Goyal 2023-07-03 06:11:47 UTC

PR is merged.

Comment 9 Vijay Avuthu 2023-07-25 07:13:39 UTC

Update:
========

installed OCP 4.13.4 + ODF 4.13.1-9 using job: https://url.corp.redhat.com/c14cbdc

1. chnaged channel to candidate-4.14 and upgrade to 4.14.0-ec.3

$ oc get clusterversion
NAME      VERSION       AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.14.0-ec.3   True        False         18h     Cluster version is 4.14.0-ec.3
$ oc adm upgrade
Cluster version is 4.14.0-ec.3

Upstream is unset, so the cluster will use an appropriate default.
Channel: candidate-4.14 (available channels: candidate-4.14)
No updates available. You may force an upgrade to a specific release image, but doing so may not be supported and may result in downtime or data loss.
$ 

> since there is no build for OCP 4.15 , we cannot initiate upgrade to 4.15

> oc get csv odf-operator.v4.13.1-rhodf -o json | jq '.metadata.annotations."olm.properties"'
"[{\"type\": \"olm.maxOpenShiftVersion\", \"value\": \"4.14\"}]"

> Verified the same on backported releases.

Comment 10 Vijay Avuthu 2023-07-25 07:23:11 UTC

moving to Verified as we don't have OCP 4.15 build and olm.maxOpenShiftVersion property is set on odf operator.

Comment 15 errata-xmlrpc 2023-08-02 16:07:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat OpenShift Data Foundation 4.13.1 security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:4437