Bug 2213604

Summary:	SELinux labels RIPE Atlas Probe/Anchor's /usr/sbin/ripe-atlas process as zebra_t
Product:	[Fedora] Fedora	Reporter:	Robert Scheck <redhat-bugzilla>
Component:	selinux-policy	Assignee:	Zdenek Pytela <zpytela>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dwalsh, lvrabec, mmalik, nknazeko, omosnacek, pkoncity, vmojzis, zpytela
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-06-29 16:44:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robert Scheck 2023-06-08 16:58:49 UTC

While trying to package RIPE Atlas Probe/Anchor for Fedora and EPEL, I had to learn that SELinux labels RIPE Atlas Probe/Anchor's /usr/sbin/ripe-atlas process as zebra_t, which makes RIPE Atlas Probe/Anchor unusable as the SELinux Zebra policy forbids many things RIPE Atlas Probe/Anchor needs to work.

Fortunately, this seems to be an unintended side effect in the SELinux policy as shipped in Fedora and RHEL:

$ grep /usr/sbin/rip /etc/selinux/targeted/contexts/files/file_contexts
/usr/sbin/rip.* --      system_u:object_r:zebra_exec_t:s0
$ 

For the Zebra/FRR component 'rip' (Routing Information Protocol) a wildcard was placed which likely impacts all software starting with '/usr/sbin/rip', even if it's not related to Zebra/FRR at all. Thus I propose the following simple fix, that does not impact Zebra/FRR's 'rip' but unbreaks RIPE Atlas Probe/Anchor's /usr/sbin/ripe-atlas (and I explicitly added a wildcard to cover possible future sub-components as well):

/usr/sbin/ripe-atlas.* -- system_u:object_r:bin_t:s0

Reproducible: Always

Actual Results:  
SELinux labels RIPE Atlas Probe/Anchor's /usr/sbin/ripe-atlas process as zebra_t when started via ripe-atlas.service

Expected Results:  
SELinux labels RIPE Atlas Probe/Anchor's /usr/sbin/ripe-atlas process as unconfined_t when started via ripe-atlas.service

Comment 1 Zdenek Pytela 2023-06-28 20:02:15 UTC

Thank you for the report, good catch. The regexp actually matches also rip89d from ax25-tools, so I changed it to 2 individual entries. All of it can probably be removed anyway later as system executables are usually in /usr/libexec now.