Bug 2213673
| Summary: | [RHEL8] Unexpected behavior when creating ext4 filesystem with invalid parameter | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | guazhang <guazhang> |
| Component: | lvm2 | Assignee: | LVM Team <lvm-team> |
| lvm2 sub component: | Udev | QA Contact: | cluster-qe <cluster-qe> |
| Status: | CLOSED MIGRATED | Docs Contact: | |
| Severity: | unspecified | ||
| Priority: | unspecified | CC: | agk, heinzm, jbrassow, msnitzer, prajnoha, spetrosi, tbzatek, vtrefny, zkabelac |
| Version: | 8.9 | Keywords: | MigratedToJIRA |
| Target Milestone: | rc | Flags: | pm-rhel:
mirror+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-09-23 19:19:26 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
@guazhang > 1. ansible-playbook -vv -i host tests_misc.yml > 2. ansible-playbook -vv -i host tests_misc_scsi_generated.yml In this case, is `host` "localhost"? I'm trying to reproduce this, but so far I have not been able to. How exactly did you run this? The problem appears to be clean up. The test: https://github.com/linux-system-roles/storage/blob/main/tests/tests_misc.yml#L72 is expecting blivet to return an error message like Failed to commit changes to disk: (FSError('format failed: 1',), '/dev/mapper/foo-test1') but instead, the error message is cannot remove existing formatting (lvmpv) and/or devices on disk 'sdb' (pool 'foo') in safe mode The test wants to create a new lvm pool with sdb and a new volume with ext4 and an invalid parameter. But for some reason the pool? or volume? still exists. @vtrefny ? How do I tell what still exists that it is complaining about? I have tried running the test multiple times in a row using qemu/kvm (I do not have a local machine with real SCSI devices) and it seems to clean up properly every time. So at this point I'm not sure what's going on. (In reply to Rich Megginson from comment #1) > @guazhang > > > 1. ansible-playbook -vv -i host tests_misc.yml > > 2. ansible-playbook -vv -i host tests_misc_scsi_generated.yml > > In this case, is `host` "localhost"? I'm trying to reproduce this, but so > far I have not been able to. How exactly did you run this? > echo "localhost ansible_connection=local" > host no other setup, I test it with my test server storageqe-104.rhts.eng.pek2.redhat.com which include some SSD. I also wasn't able to reproduce this. @guazhang I can't find blivet.log in the beaker job, is it available somewhere? From the role output it looks like the cleanup worked as expected and everything, including the lvmpv format on sdb should be removed, but it's hard to tell what actually happened without the blivet.log.
"actions": [
{
"action": "destroy format",
"device": "/dev/mapper/foo-test1",
"fs_type": "ext4"
},
{
"action": "destroy device",
"device": "/dev/mapper/foo-test1",
"fs_type": null
},
{
"action": "destroy device",
"device": "/dev/foo",
"fs_type": null
},
{
"action": "destroy format",
"device": "/dev/sdb",
"fs_type": "lvmpv"
}
Hi, retest the job and get the log https://beaker.engineering.redhat.com/recipes/14123470#task162043349 https://beaker.engineering.redhat.com/recipes/14123470/tasks/162043355/logs/4.18.0-497.el8.x86_64.tar.bz2 The udev database is in inconsistent state after the pvremove call we do. The /dev/sdb PV is removed but udev still thinks it is formatted to lvmpv: --------------- # lsblk -f /dev/sdb NAME FSTYPE LABEL UUID MOUNTPOINT sdb LVM2_member KvVOZf-1tc2-c1E1-c8Vr-aSH3-LZJ3-W3liPZ # udevadm info /dev/sdb ... E: ID_FS_TYPE=LVM2_member E: ID_FS_USAGE=raid E: ID_FS_UUID=KvVOZf-1tc2-c1E1-c8Vr-aSH3-LZJ3-W3liPZ --------------- but the disk is empty: --------------- # pvremove /dev/sdb No PV found on device /dev/sdb. # wipefs /dev/sdb # --------------- Moving to lvm for further investigation. Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug. This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there. Due to differences in account names between systems, some fields were not replicated. Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information. To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer. You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like: "Bugzilla Bug" = 1234567 In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information. |
Description of problem: storage roles regression found the error, please have a look Version-Release number of selected component (if applicable): ansible-core-2.15.0-1.el8.x86_64 rhel-system-roles-1.22.0-0.9.el8.noarch RHEL-8.9.0-20230603.20 BaseOS x86_64 How reproducible: Steps to Reproduce: 1. ansible-playbook -vv -i host tests_misc.yml 2. ansible-playbook -vv -i host tests_misc_scsi_generated.yml 3. Actual results: Expected results: Additional info: TASK [rhel-system-roles.storage : Make sure required packages are installed] *** task path: /usr/share/ansible/roles/rhel-system-roles.storage/tasks/main-blivet.yml:39 skipping: [localhost] => {"changed": false, "false_condition": "storage_skip_checks is not defined or not \"packages_installed\" in storage_skip_checks", "skip_reason": "Conditional result was False"} TASK [rhel-system-roles.storage : Get service facts] *************************** task path: /usr/share/ansible/roles/rhel-system-roles.storage/tasks/main-blivet.yml:46 skipping: [localhost] => {"changed": false, "false_condition": "storage_skip_checks is not defined or not \"service_facts\" in storage_skip_checks", "skip_reason": "Conditional result was False"} TASK [rhel-system-roles.storage : Set storage_cryptsetup_services] ************* task path: /usr/share/ansible/roles/rhel-system-roles.storage/tasks/main-blivet.yml:53 ok: [localhost] => {"ansible_facts": {"storage_cryptsetup_services": []}, "changed": false} TASK [rhel-system-roles.storage : Mask the systemd cryptsetup services] ******** task path: /usr/share/ansible/roles/rhel-system-roles.storage/tasks/main-blivet.yml:67 skipping: [localhost] => {"changed": false, "skipped_reason": "No items in the list"} TASK [rhel-system-roles.storage : Manage the pools and volumes to match the specified state] *** task path: /usr/share/ansible/roles/rhel-system-roles.storage/tasks/main-blivet.yml:73 fatal: [localhost]: FAILED! => {"actions": [], "changed": false, "crypts": [], "leaves": [], "mounts": [], "msg": "cannot remove existing formatting (lvmpv) and/or devices on disk 'sdb' (pool 'foo') in safe mode", "packages": [], "pools": [], "volumes": []} TASK [rhel-system-roles.storage : Failed message] ****************************** task path: /usr/share/ansible/roles/rhel-system-roles.storage/tasks/main-blivet.yml:95 fatal: [localhost]: FAILED! => {"changed": false, "msg": {"actions": [], "changed": false, "crypts": [], "failed": true, "invocation": {"module_args": {"disklabel_type": null, "diskvolume_mkfs_option_map": {}, "packages_only": false, "pool_defaults": {"disks": [], "encryption": false, "encryption_cipher": null, "encryption_key": null, "encryption_key_size": null, "encryption_luks_version": null, "encryption_password": null, "raid_chunk_size": null, "raid_device_count": null, "raid_level": null, "raid_metadata_version": null, "raid_spare_count": null, "state": "present", "type": "lvm", "volumes": []}, "pools": [{"disks": ["sdb"], "encryption": false, "encryption_cipher": null, "encryption_key": null, "encryption_key_size": null, "encryption_luks_version": null, "encryption_password": null, "name": "foo", "raid_chunk_size": null, "raid_device_count": null, "raid_level": null, "raid_metadata_version": null, "raid_spare_count": null, "state": "present", "type": "lvm", "volumes": [{"cache_devices": [], "cache_mode": null, "cache_size": null, "cached": null, "compression": null, "deduplication": null, "encryption": null, "encryption_cipher": null, "encryption_key": null, "encryption_key_size": null, "encryption_luks_version": null, "encryption_password": null, "fs_create_options": "-Fb 512", "fs_label": "", "fs_type": "ext4", "mount_group": null, "mount_mode": null, "mount_options": null, "mount_point": "/opt/test1", "mount_user": null, "name": "test1", "raid_disks": [], "raid_level": null, "raid_stripe_size": null, "size": "4g", "state": "present", "thin": false, "thin_pool_name": null, "thin_pool_size": null, "type": null, "vdo_pool_size": null}]}], "safe_mode": true, "use_partitions": null, "volume_defaults": {"cache_devices": [], "cache_mode": null, "cache_size": 0, "cached": false, "compression": null, "deduplication": null, "disks": [], "encryption": false, "encryption_cipher": null, "encryption_key": null, "encryption_key_size": null, "encryption_luks_version": null, "encryption_password": null, "fs_create_options": "", "fs_label": "", "fs_overwrite_existing": true, "fs_type": "xfs", "mount_check": 0, "mount_device_identifier": "uuid", "mount_options": "defaults", "mount_passno": 0, "mount_point": "", "raid_chunk_size": null, "raid_device_count": null, "raid_level": null, "raid_metadata_version": null, "raid_spare_count": null, "raid_stripe_size": null, "size": 0, "state": "present", "thin": null, "thin_pool_name": null, "thin_pool_size": null, "type": "lvm", "vdo_pool_size": null}, "volumes": []}}, "leaves": [], "mounts": [], "msg": "cannot remove existing formatting (lvmpv) and/or devices on disk 'sdb' (pool 'foo') in safe mode", "packages": [], "pools": [], "volumes": []}} TASK [rhel-system-roles.storage : Unmask the systemd cryptsetup services] ****** task path: /usr/share/ansible/roles/rhel-system-roles.storage/tasks/main-blivet.yml:99 skipping: [localhost] => {"changed": false, "skipped_reason": "No items in the list"} TASK [Check that we failed in the role] **************************************** task path: /usr/share/ansible/roles/rhel-system-roles.storage/tests/verify-role-failed.yml:20 ok: [localhost] => { "changed": false, "msg": "All assertions passed" } TASK [Verify the blivet output and error message are correct] ****************** task path: /usr/share/ansible/roles/rhel-system-roles.storage/tests/verify-role-failed.yml:25 fatal: [localhost]: FAILED! => { "assertion": "blivet_output.msg is search(__storage_failed_regex)", "changed": false, "evaluated_to": false, "msg": "Unexpected behavior when creating ext4 filesystem with invalid parameter" } PLAY RECAP ********************************************************************* localhost : ok=178 changed=4 unreachable=0 failed=1 skipped=150 rescued=2 ignored=0 STDERR: RETURN:2 https://beaker.engineering.redhat.com/recipes/14051127#task161440046